Fixes to iOS/tv-casting-app's build due to zap changes #24713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharadb-amazon
force-pushed
the
build-20230127
branch
from
a68360a to
eb01e12
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
sharadb-amazon
force-pushed
the
build-20230127
branch
from
eb01e12 to
8d36e6e
Compare
|
PR #24713: Size comparison from 055329f to 8d36e6e Increases (1 build for qpg)
Decreases (13 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, psoc6, qpg, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
Should building this app be part of CI? Even if just master CI since it is unlikely to get broken without breaking the other builds. |
bzbarsky-apple
approved these changes
Jan 28, 2023
andy31415
approved these changes
Jan 30, 2023
|
@andy31415 - yes, this iOS app should be built as part of CI. Tracking the required changes as part of #24736 Can you point me to any code/configuration that triggers the build of another iOS Matter app on CI? |
@sharadb-amazon Various builds happening here for darwin (xcode builds) https://github.com/project-chip/connectedhomeip/blob/master/.github/workflows/darwin.yaml and here for general builds (including darwin): https://github.com/project-chip/connectedhomeip/blob/master/.github/workflows/build.yaml#L350 Having said that, the builds are very slow, so if these are unlikely to change frequently (I believe that is the case), we may want instead to split off a master-only build like android does: https://github.com/project-chip/connectedhomeip/blob/master/.github/workflows/full-android.yaml#L18 The full android builds only happen on master, where as the smoke test android happens on every PR. |
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to changes made in this PR: #23962
Change summary
After the PR linked above was merged the build for the iOS tv-casting-app started failing because it could not find a number of header files. This PR makes some adjustments in how a few header files are included in the iOS tv-casting-app so that its build does not fail.
Testing
Built the iOS tv-casting-app with xcode and ran it on iPhone