[dnssd] Replace invalid forced reset logic #24698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The platform implementation of DNS-SD contains a mechanism for restarting the advertising when the platform returns the CHIP_ERROR_FORCED_RESET error. This mechanism is broken as it assumes that only one operational service is used and it uses extra RAM although it is only used by Linux. Switch to an event-based approach that allows the DNS-SD server to restart the advertising when needed.
Currently, the platform implementation of DNS-SD uses a boolean member to indicate if the backend has already been initialized, but the initialization is asynchronous so it may happen that the initialization is invoked twice. Add another "initializing" state to handle that case.
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
pjzander-signify,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #24698: Size comparison from 4820cbd to 6ee2fa7 Increases (26 builds for bl602, bl702, cc13x2_26x2, linux, nrfconnect, psoc6)
Decreases (29 builds for bl702, cc13x2_26x2, cyw30739, efr32, k32w, nrfconnect, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 28, 2023
andy31415
approved these changes
Jan 30, 2023
kkasperczyk-no
pushed a commit
to kkasperczyk-no/connectedhomeip
that referenced
this pull request
Feb 1, 2023
* [dnssd] Replace invalid forced reset logic The platform implementation of DNS-SD contains a mechanism for restarting the advertising when the platform returns the CHIP_ERROR_FORCED_RESET error. This mechanism is broken as it assumes that only one operational service is used and it uses extra RAM although it is only used by Linux. Switch to an event-based approach that allows the DNS-SD server to restart the advertising when needed. * [dnssd] Make sure initialization is not run twice Currently, the platform implementation of DNS-SD uses a boolean member to indicate if the backend has already been initialized, but the initialization is asynchronous so it may happen that the initialization is invoked twice. Add another "initializing" state to handle that case. * Improve comment * Fix build
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* [dnssd] Replace invalid forced reset logic The platform implementation of DNS-SD contains a mechanism for restarting the advertising when the platform returns the CHIP_ERROR_FORCED_RESET error. This mechanism is broken as it assumes that only one operational service is used and it uses extra RAM although it is only used by Linux. Switch to an event-based approach that allows the DNS-SD server to restart the advertising when needed. * [dnssd] Make sure initialization is not run twice Currently, the platform implementation of DNS-SD uses a boolean member to indicate if the backend has already been initialized, but the initialization is asynchronous so it may happen that the initialization is invoked twice. Add another "initializing" state to handle that case. * Improve comment * Fix build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The platform implementation of DNS-SD contains a mechanism for restarting the advertising when the platform returns the CHIP_ERROR_FORCED_RESET error. This mechanism is broken as it assumes that only one operational service is used and it uses extra RAM although it is only used by Linux.
Switch to an event-based approach that allows the DNS-SD server to restart the advertising when needed.
Additionally, handle the case in which
DiscoveryImplPlatform::InitImpl()is called while the initialization is in progress