Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a --skip-build option to docker image builds #23836

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Add a --skip-build option to docker image builds #23836

merged 3 commits into from
Dec 1, 2022

Conversation

andy31415
Copy link
Contributor

This is to allow complete separation between 'build' and 'push' operations. It seems that when using automated builds, I had docker login expire and this makes image pushing fails for builds that take a long time. Looking to fix that.

@github-actions
Copy link

github-actions bot commented Nov 30, 2022 •
edited
Loading

PR #23836: Size comparison from 5839cf2 to 1ab26e2

Increases (5 builds for bl602, esp32, k32w, psoc6, telink)
platform target config section 5839cf2 1ab26e2 change % change
bl602 lighting-app bl602+rpc .text 1069134 1069136 2 0.0
esp32 all-clusters-app c3devkit (read only) 1214740 1214742 2 0.0
.flash.text 1214740 1214742 2 0.0
k32w contact k32w0+release (read/write) 662500 662516 16 0.0
.text 564172 564188 16 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26773950 26773951 1 0.0
telink thermostat tlsr9518adk80d text 554338 554340 2 0.0
Decreases (5 builds for bl602, bl702, psoc6, telink)
platform target config section 5839cf2 1ab26e2 change % change
bl602 lighting-app bl602 .text 1037806 1037802 -4 -0.0
bl702 lighting-app bl702 .debug_info 39160271 39160270 -1 -0.0
.text 956016 956014 -2 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27036449 27036448 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 22459105 22459104 -1 -0.0
telink lighting-app tlsr9518adk80d text 625610 625608 -2 -0.0
Full report (44 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 5839cf2 1ab26e2 change % change
bl602 lighting-app bl602 (read/write) 1355018 1355018 0 0.0
.bss 87057 87057 0 0.0
.data 9984 9984 0 0.0
.text 1037806 1037802 -4 -0.0
bl602+rpc (read/write) 1400706 1400706 0 0.0
.bss 95105 95105 0 0.0
.data 10384 10384 0 0.0
.text 1069134 1069136 2 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195423 1195423 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1524554 1524554 0 0.0
.debug_aranges 132464 132464 0 0.0
.debug_frame 485972 485972 0 0.0
.debug_info 39160271 39160270 -1 -0.0
.debug_line 5127060 5127060 0 0.0
.debug_loc 3373858 3373858 0 0.0
.debug_ranges 361288 361288 0 0.0
.debug_str 3475303 3475303 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116288 116288 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 568475 568475 0 0.0
.symtab 172016 172016 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956016 956014 -2 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284059 1284059 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75214 75214 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1671640 1671640 0 0.0
.debug_aranges 140600 140600 0 0.0
.debug_frame 513408 513408 0 0.0
.debug_info 43456979 43456979 0 0.0
.debug_line 5517237 5517237 0 0.0
.debug_loc 3569239 3569239 0 0.0
.debug_ranges 384776 384776 0 0.0
.debug_str 3874896 3874896 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130000 130000 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 628629 628629 0 0.0
.symtab 190160 190160 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030116 1030116 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588326 588326 0 0.0
.app_xip_area 464576 464576 0 0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592034 592034 0 0.0
.app_xip_area 462988 462988 0 0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544714 544714 0 0.0
.app_xip_area 426476 426476 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976092 976092 0 0.0
.bss 152260 152260 0 0.0
.data 2168 2168 0 0.0
.text 821644 821644 0 0.0
BRD4161A+rs911x (read/write) 1037632 1037632 0 0.0
.bss 186736 186736 0 0.0
.data 2012 2012 0 0.0
.text 848864 848864 0 0.0
BRD4187C (read/write) 1149196 1149196 0 0.0
.bss 138656 138656 0 0.0
.data 2516 2516 0 0.0
.text 983428 983428 0 0.0
lock-app BRD4161A+wf200 (read/write) 1163288 1163288 0 0.0
.bss 158304 158304 0 0.0
.data 2020 2020 0 0.0
.text 1002944 1002944 0 0.0
window-app BRD4187C (read/write) 1141736 1141736 0 0.0
.bss 140072 140072 0 0.0
.data 2540 2540 0 0.0
.text 974528 974528 0 0.0
esp32 all-clusters-app c3devkit (read only) 1214740 1214742 2 0.0
(read/write) 1786670 1786670 0 0.0
.dram0.bss 76688 76688 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 256496 256496 0 0.0
.flash.text 1214740 1214742 2 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1225491 1225491 0 0.0
(read/write) 562636 562636 0 0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 313608 313608 0 0.0
.flash.text 1220107 1220107 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 662500 662516 16 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 564172 564188 16 0.0
light k32w0+release (read/write) 673080 673080 0 0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 593380 593380 0 0.0
lock k32w0+release (read/write) 634044 634044 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 553564 553564 0 0.0
linux all-clusters-app debug (read only) 3083801 3083801 0 0.0
(read/write) 158504 158504 0 0.0
.bss 62464 62464 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 87144 87144 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281195 281195 0 0.0
.text 2618114 2618114 0 0.0
all-clusters-minimal-app debug (read only) 2909417 2909417 0 0.0
(read/write) 149904 149904 0 0.0
.bss 61664 61664 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 79512 79512 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280651 280651 0 0.0
.text 2447314 2447314 0 0.0
bridge-app debug+rpc (read only) 2406689 2406689 0 0.0
(read/write) 129608 129608 0 0.0
.bss 51008 51008 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68776 68776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 210816 210816 0 0.0
.text 2028514 2028514 0 0.0
chip-tool debug (read only) 11099569 11099569 0 0.0
(read/write) 659616 659616 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 624352 624352 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 592965 592965 0 0.0
.text 8980164 8980164 0 0.0
lighting-app debug+rpc (read only) 2638913 2638913 0 0.0
(read/write) 132360 132360 0 0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73896 73896 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227808 227808 0 0.0
.text 2234546 2234546 0 0.0
lock-app debug (read only) 2596073 2596073 0 0.0
(read/write) 127376 127376 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70840 70840 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244072 244072 0 0.0
.text 2180290 2180290 0 0.0
ota-provider-app debug (read only) 2390433 2390433 0 0.0
(read/write) 120904 120904 0 0.0
.bss 47936 47936 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 64760 64760 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 216520 216520 0 0.0
.text 2005362 2005362 0 0.0
ota-requestor-app debug (read only) 2557217 2557217 0 0.0
(read/write) 129248 129248 0 0.0
.bss 50464 50464 0 0.0
.data 2496 2496 0 0.0
.data.rel.ro 70120 70120 0 0.0
.dynamic 608 608 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 223568 223568 0 0.0
.text 2156002 2156002 0 0.0
shell debug (read only) 2619297 2619297 0 0.0
(read/write) 142968 142968 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78040 78040 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239442 239442 0 0.0
.text 2220338 2220338 0 0.0
tv-app debug (read only) 3253905 3253905 0 0.0
(read/write) 262152 262152 0 0.0
.bss 170808 170808 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80384 80384 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268344 268344 0 0.0
.text 2791570 2791570 0 0.0
tv-casting-app debug (read only) 5588809 5588809 0 0.0
(read/write) 162080 162080 0 0.0
.bss 52120 52120 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101408 101408 0 0.0
.dynamic 608 608 0 0.0
.got 4912 4912 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 355801 355801 0 0.0
.text 4956882 4956882 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453760 2453760 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1416404 1416404 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1190723 1190723 0 0.0
bss 145289 145289 0 0.0
rodata 144408 144408 0 0.0
text 819872 819872 0 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1360850 1360850 0 0.0
bss 105228 105228 0 0.0
rodata 211512 211512 0 0.0
text 759626 759626 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136387 1136387 0 0.0
bss 144524 144524 0 0.0
rodata 120728 120728 0 0.0
text 790040 790040 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1748436 1748436 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235876 1235876 0 0.0
.debug_aranges 110760 110760 0 0.0
.debug_frame 371660 371660 0 0.0
.debug_info 27036449 27036448 -1 -0.0
.debug_line 3691367 3691367 0 0.0
.debug_loc 3616201 3616201 0 0.0
.debug_ranges 340832 340832 0 0.0
.debug_str 3444845 3444845 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571601 571601 0 0.0
.symtab 422016 422016 0 0.0
.text 1548672 1548672 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1690956 1690956 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227767 1227767 0 0.0
.debug_aranges 110232 110232 0 0.0
.debug_frame 374716 374716 0 0.0
.debug_info 26773950 26773951 1 0.0
.debug_line 3712355 3712355 0 0.0
.debug_loc 3603807 3603807 0 0.0
.debug_ranges 339448 339448 0 0.0
.debug_str 3433857 3433857 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535690 535690 0 0.0
.symtab 408448 408448 0 0.0
.text 1491928 1491928 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1609156 1609156 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062290 1062290 0 0.0
.debug_aranges 102432 102432 0 0.0
.debug_frame 345052 345052 0 0.0
.debug_info 22239744 22239744 0 0.0
.debug_line 3281695 3281695 0 0.0
.debug_loc 3301727 3301727 0 0.0
.debug_ranges 304712 304712 0 0.0
.debug_str 3239443 3239443 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472015 472015 0 0.0
.symtab 376816 376816 0 0.0
.text 1418312 1418312 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1642596 1642596 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1064298 1064298 0 0.0
.debug_aranges 102816 102816 0 0.0
.debug_frame 346848 346848 0 0.0
.debug_info 22459105 22459104 -1 -0.0
.debug_line 3276279 3276279 0 0.0
.debug_loc 3323104 3323104 0 0.0
.debug_ranges 306080 306080 0 0.0
.debug_str 3255275 3255275 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473677 473677 0 0.0
.symtab 378416 378416 0 0.0
.text 1446760 1446760 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150852 1150852 0 0.0
.bss 97628 97628 0 0.0
.data 840 840 0 0.0
.text 597952 597952 0 0.0
lock-app qpg6105+debug (read/write) 1116724 1116724 0 0.0
.bss 93100 93100 0 0.0
.data 836 836 0 0.0
.text 563820 563820 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 939004 939004 0 0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 650268 650268 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 876972 876972 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 614222 614222 0 0.0
light-switch-app tlsr9518adk80d (read/write) 792192 792192 0 0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 555366 555366 0 0.0
lighting-app tlsr9518adk80d (read/write) 876512 876512 0 0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 625610 625608 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 806552 806552 0 0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 566704 566704 0 0.0
thermostat tlsr9518adk80d (read/write) 793356 793356 0 0.0
bss 73852 73852 0 0.0
noinit 43480 43480 0 0.0
text 554338 554340 2 0.0

@andy31415
Copy link
Contributor Author

fast tracking: over 24h on a change that does not affect direct SDK functionality but would unblock a bot to auto-build docker images (which would be very useful)

@andy31415 andy31415 merged commit 324135b into project-chip:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track integrations review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy31415 @yufengwangca