-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Support for ESP32C2 and changes to not initialized BLE for already provisioned nodes #22967
Conversation
the advertising packet
If ble is only used for commissioning then there is no use to initialize the ble. Also, renamed the config option for the purpose to make it more aligned.
PR #22967: Size comparison from a334714 to ea0c875 Increases (7 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (1 build for cc13x2_26x2)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment. LGTM otherwise
@shubhamdp I think we also need an issue to be filed for a PR |
@dhrishi, PR template read the following, so thought of not filing an issue.
|
…ready provisioned nodes (project-chip#22967) * [ESP32]: Remove device name from the ble log as we do not add that in the advertising packet * Remove the sdkconfig.old * [ESP32]: Platform, doc, example change to support ESP32C2 * [ESP32]: Do not initialize BLE if wifi/thread is already provisioned. If ble is only used for commissioning then there is no use to initialize the ble. Also, renamed the config option for the purpose to make it more aligned. * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
…ready provisioned nodes (project-chip#22967) * [ESP32]: Remove device name from the ble log as we do not add that in the advertising packet * Remove the sdkconfig.old * [ESP32]: Platform, doc, example change to support ESP32C2 * [ESP32]: Do not initialize BLE if wifi/thread is already provisioned. If ble is only used for commissioning then there is no use to initialize the ble. Also, renamed the config option for the purpose to make it more aligned. * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
…ready provisioned nodes (#22967) (#22973) * [ESP32]: Remove device name from the ble log as we do not add that in the advertising packet * Remove the sdkconfig.old * [ESP32]: Platform, doc, example change to support ESP32C2 * [ESP32]: Do not initialize BLE if wifi/thread is already provisioned. If ble is only used for commissioning then there is no use to initialize the ble. Also, renamed the config option for the purpose to make it more aligned. * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Restyled.io <commits@restyled.io>
Issues
Description
BLE is initialized every time even if device is commissioned and BLE is not being used in either subsequent boot or after device gets commissioned. Added a config option which let user select whether to deinit BLE after commissioning and on boot if not to initialize BLE if WiFi/Thread is already provisioned.
ESP32C2 was introduced some time earlier and supported on IDF v5.0-beta1. Currently v5.0-beta1 is used for ESP32H2(Thread device), so extending the support in SDK to support ESP32C2.
Removed the BLE device name from the log as it is not being advertised in the BLE advertisement data
Removing the
sdkconfig.old
present inall-clusters-minimal-app/esp32
as this is autogenerated and not required.