[ESP32] Support for ESP32C2 and changes to not initialized BLE for already provisioned nodes #22967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the advertising packet
If ble is only used for commissioning then there is no use to initialize the ble. Also, renamed the config option for the purpose to make it more aligned.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple and
jelderton
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
msandstedt,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #22967: Size comparison from a334714 to ea0c875 Increases (7 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (1 build for cc13x2_26x2)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
dhrishi
approved these changes
Sep 30, 2022
|
@shubhamdp I think we also need an issue to be filed for a PR |
|
@dhrishi, PR template read the following, so thought of not filing an issue.
|
andy31415
approved these changes
Sep 30, 2022
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Sep 30, 2022
…ready provisioned nodes (project-chip#22967) * [ESP32]: Remove device name from the ble log as we do not add that in the advertising packet * Remove the sdkconfig.old * [ESP32]: Platform, doc, example change to support ESP32C2 * [ESP32]: Do not initialize BLE if wifi/thread is already provisioned. If ble is only used for commissioning then there is no use to initialize the ble. Also, renamed the config option for the purpose to make it more aligned. * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
sharad-patil24
pushed a commit
to sharad-patil24/connectedhomeip
that referenced
this pull request
Sep 30, 2022
…ready provisioned nodes (project-chip#22967) * [ESP32]: Remove device name from the ble log as we do not add that in the advertising packet * Remove the sdkconfig.old * [ESP32]: Platform, doc, example change to support ESP32C2 * [ESP32]: Do not initialize BLE if wifi/thread is already provisioned. If ble is only used for commissioning then there is no use to initialize the ble. Also, renamed the config option for the purpose to make it more aligned. * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
andy31415
pushed a commit
that referenced
this pull request
Sep 30, 2022
…ready provisioned nodes (#22967) (#22973) * [ESP32]: Remove device name from the ble log as we do not add that in the advertising packet * Remove the sdkconfig.old * [ESP32]: Platform, doc, example change to support ESP32C2 * [ESP32]: Do not initialize BLE if wifi/thread is already provisioned. If ble is only used for commissioning then there is no use to initialize the ble. Also, renamed the config option for the purpose to make it more aligned. * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Description
BLE is initialized every time even if device is commissioned and BLE is not being used in either subsequent boot or after device gets commissioned. Added a config option which let user select whether to deinit BLE after commissioning and on boot if not to initialize BLE if WiFi/Thread is already provisioned.
ESP32C2 was introduced some time earlier and supported on IDF v5.0-beta1. Currently v5.0-beta1 is used for ESP32H2(Thread device), so extending the support in SDK to support ESP32C2.
Removed the BLE device name from the log as it is not being advertised in the BLE advertisement data
Removing the
sdkconfig.oldpresent inall-clusters-minimal-app/esp32as this is autogenerated and not required.