-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[session][test] Extend TestSessionManagerDispatch with group test #22769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #22769: Size comparison from 847f450 to a604455 Decreases (3 builds for bl602, bl702)
Full report (6 builds for bl602, bl702, qpg)
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda and
mlepage-google
September 20, 2022 17:51
pullapprove
bot
requested review from
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
September 20, 2022 17:51
PR #22769: Size comparison from 847f450 to 23952f9 Increases (1 build for psoc6)
Decreases (6 builds for bl602, k32w, nrfconnect, psoc6)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
turon
commented
Sep 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update to capture the suggested TODO items.
This was referenced Sep 22, 2022
turon
force-pushed
the
test/session/manager
branch
from
September 22, 2022 21:39
9265e4a
to
5ebf0a6
Compare
PR #22769: Size comparison from edb93a0 to 5ebf0a6 Increases (5 builds for bl602, cc13x2_26x2, qpg, telink)
Decreases (7 builds for bl602, cc13x2_26x2, psoc6, telink)
Full report (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Sep 23, 2022
turon
changed the title
[session][test] Extend TestSessionManagerDiaspatch with group test
[session][test] Extend TestSessionManagerDispatch with group test
Sep 23, 2022
turon
force-pushed
the
test/session/manager
branch
from
September 23, 2022 15:51
ecbd242
to
a8e69db
Compare
PR #22769: Size comparison from a90c6b1 to a8e69db Increases (7 builds for bl602, cc13x2_26x2, psoc6, qpg, telink)
Decreases (4 builds for cc13x2_26x2, esp32, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
saurabhst
approved these changes
Sep 23, 2022
sharad-patil24
pushed a commit
to sharad-patil24/connectedhomeip
that referenced
this pull request
Sep 30, 2022
…oject-chip#22769) * [session][test] Add group message test vector. * [session][test] Add short payload secure unicast message test vector. * [restyle] * [test] Resolve review comments. Decouple TestInjectGroupSession from nl_unit. * [test] Fix group name string too large.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Originally posted by @tcarmelveilleux in [session][test] Added unit test coverage of OnMessageReceive decrypt path. #22736 (comment)
Change overview
Adds support for groupcast test vectors for message decrypt.
Adds non-zero length payload test vector for pase unicast message decrypt.