Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix android compilation: missing cast when formatting value in string #22382

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Fix android compilation: missing cast when formatting value in string #22382

merged 2 commits into from
Sep 2, 2022

Conversation

andy31415
Copy link
Contributor

Problem

Failure in tv-app build: invalid cast for %d

Change overview

Fixes builds, this seems to be the only remaining build failure for cloudbuild 'all' build.

Testing

Ran locally (tool a very long time)

./scripts/build/build_examples.py --enable-flashbundle --target-glob '*' --skip-target-glob '{imx-*,tizen-*,*-androidstudio-*,*-tests*,*-chip-test}' build --create-archives /workspace/artifacts/

@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Sep 2, 2022
@andy31415 andy31415 merged commit 9c2f087 into project-chip:master Sep 2, 2022
bzbarsky-apple
bzbarsky-apple reviewed Sep 2, 2022
View reviewed changes
examples/tv-app/android/java/AppPlatformShellCommands-JNI.cpp
@@ -57,7 +57,7 @@ static CHIP_ERROR pairApp(bool printHeader, size_t index)
if (state == nullptr)
{
char str[64];
sprintf(str, "udc client[%d] null \r\n", index);
sprintf(str, "udc client[%ld] null \r\n", static_cast<long>(index));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andy31415 This should probably have just cast to unsigned long instead of long.....

@github-actions
Copy link

github-actions bot commented Sep 2, 2022 •
edited
Loading

PR #22382: Size comparison from c33f59c to c04584b

Increases (4 builds for cc13x2_26x2, esp32, psoc6, qpg)
platform target config section c33f59c c04584b change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 676395 676403 8 0.0
.text 598848 598856 8 0.0
esp32 all-clusters-app m5stack (read/write) 490916 490924 8 0.0
.flash.rodata 247456 247464 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26715280 26715281 1 0.0
qpg lighting-app qpg6105+debug (read/write) 1129140 1129148 8 0.0
.text 576236 576244 8 0.0
Decreases (4 builds for bl602, cc13x2_26x2, psoc6, telink)
platform target config section c33f59c c04584b change % change
bl602 lighting-app bl602+rpc (read/write) 1431830 1431822 -8 -0.0
.text 1084328 1084324 -4 -0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 165324 165316 -8 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22293933 22293932 -1 -0.0
telink light-switch-app tlsr9518adk80d text 571452 571450 -2 -0.0
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section c33f59c c04584b change % change
bl602 lighting-app bl602 (read/write) 1386174 1386174 0 0.0
.bss 120298 120298 0 0.0
.data 4488 4488 0 0.0
.text 1052568 1052568 0 0.0
bl602+rpc (read/write) 1431830 1431822 -8 -0.0
.bss 127730 127730 0 0.0
.data 4600 4600 0 0.0
.text 1084328 1084324 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675335 675335 0 0.0
(read/write) 176072 176072 0 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89215 89215 0 0.0
.text 585808 585808 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640047 640047 0 0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78367 78367 0 0.0
.text 561360 561360 0 0.0
lock-ftd LP_CC2652R7 (read only) 676395 676403 8 0.0
(read/write) 165324 165316 -8 -0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77067 77067 0 0.0
.text 598848 598856 8 0.0
lock-mtd LP_CC2652R7 (read only) 659355 659355 0 0.0
(read/write) 178052 178052 0 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102323 102323 0 0.0
.text 556552 556552 0 0.0
pump-app LP_CC2652R7 (read only) 685223 685223 0 0.0
(read/write) 157200 157200 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 90079 90079 0 0.0
.text 594660 594660 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669715 669715 0 0.0
(read/write) 172820 172820 0 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85627 85627 0 0.0
.text 583608 583608 0 0.0
shell LP_CC2652R7 (read only) 665986 665986 0 0.0
(read/write) 180940 180940 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85770 85770 0 0.0
.text 579900 579900 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586866 586866 0 0.0
.app_xip_area 463524 463524 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592610 592610 0 0.0
.app_xip_area 464484 464484 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599794 599794 0 0.0
.app_xip_area 477172 477172 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1108512 1108512 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 970088 970088 0 0.0
BRD4161A+rpc (read/write) 972156 972156 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 819040 819040 0 0.0
BRD4161A+rs911x (read/write) 1002228 1002228 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 830976 830976 0 0.0
lock-app BRD4161A+wf200 (read/write) 1150288 1150288 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 995948 995948 0 0.0
window-app BRD4161A (read/write) 1099752 1099752 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 959864 959864 0 0.0
esp32 all-clusters-app c3devkit (read only) 1033886 1033886 0 0.0
(read/write) 1493646 1493646 0 0.0
.dram0.bss 71120 71120 0 0.0
.dram0.data 13696 13696 0 0.0
.flash.rodata 218160 218160 0 0.0
.flash.text 1033886 1033886 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1086503 1086503 0 0.0
(read/write) 490916 490924 8 0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 247456 247464 8 0.0
.flash.text 1081119 1081119 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648188 648188 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 572680 572680 0 0.0
lock k32w0+release (read/write) 705184 705184 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 629220 629220 0 0.0
linux all-clusters-app debug (read only) 3045065 3045065 0 0.0
(read/write) 156032 156032 0 0.0
.bss 61792 61792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85768 85768 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 275435 275435 0 0.0
.text 2590194 2590194 0 0.0
all-clusters-minimal-app debug (read only) 2880865 2880865 0 0.0
(read/write) 147632 147632 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78264 78264 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 275595 275595 0 0.0
.text 2428610 2428610 0 0.0
bridge-app debug+rpc (read only) 2378665 2378665 0 0.0
(read/write) 127752 127752 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67640 67640 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 204296 204296 0 0.0
.text 2011458 2011458 0 0.0
chip-tool debug (read only) 10944361 10944361 0 0.0
(read/write) 657320 657320 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622288 622288 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 569045 569045 0 0.0
.text 8854500 8854500 0 0.0
chip-tool-ipv6only arm64 (read only) 1031920 1031920 0 0.0
(read/write) 705169 705169 0 0.0
.bss 33297 33297 0 0.0
.data 3280 3280 0 0.0
.data.rel.ro 649784 649784 0 0.0
.dynamic 560 560 0 0.0
.got 13840 13840 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 499300 499300 0 0.0
.text 8167492 8167492 0 0.0
lighting-app debug+rpc (read only) 2604057 2604057 0 0.0
(read/write) 130536 130536 0 0.0
.bss 49792 49792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72680 72680 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221104 221104 0 0.0
.text 2211762 2211762 0 0.0
lock-app debug (read only) 2587073 2587073 0 0.0
(read/write) 125712 125712 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69688 69688 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 238128 238128 0 0.0
.text 2182002 2182002 0 0.0
ota-provider-app debug (read only) 2364313 2364313 0 0.0
(read/write) 119144 119144 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63512 63512 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 210104 210104 0 0.0
.text 1990450 1990450 0 0.0
ota-requestor-app debug (read only) 2529561 2529561 0 0.0
(read/write) 127552 127552 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68920 68920 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 216832 216832 0 0.0
.text 2139826 2139826 0 0.0
shell debug (read only) 2613369 2613369 0 0.0
(read/write) 142184 142184 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77376 77376 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 235538 235538 0 0.0
.text 2219122 2219122 0 0.0
thermostat-no-ble arm64 (read only) 2362964 2362964 0 0.0
(read/write) 141857 141857 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76112 76112 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141404 141404 0 0.0
.text 1983520 1983520 0 0.0
tv-app debug (read only) 3191545 3191545 0 0.0
(read/write) 258040 258040 0 0.0
.bss 167352 167352 0 0.0
.data 4752 4752 0 0.0
.data.rel.ro 79368 79368 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 260104 260104 0 0.0
.text 2741410 2741410 0 0.0
tv-casting-app debug (read only) 5509873 5509873 0 0.0
(read/write) 160536 160536 0 0.0
.bss 51352 51352 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100304 100304 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 345073 345073 0 0.0
.text 4892898 4892898 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455184 2455184 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417828 1417828 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181071 1181071 0 0.0
bss 143641 143641 0 0.0
rodata 143504 143504 0 0.0
text 814980 814980 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160251 1160251 0 0.0
bss 142868 142868 0 0.0
rodata 135092 135092 0 0.0
text 803372 803372 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1742732 1742732 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221450 1221450 0 0.0
.debug_aranges 111728 111728 0 0.0
.debug_frame 372964 372964 0 0.0
.debug_info 26715280 26715281 1 0.0
.debug_line 3657380 3657380 0 0.0
.debug_loc 3573063 3573063 0 0.0
.debug_ranges 338424 338424 0 0.0
.debug_str 3427396 3427396 0 0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570587 570587 0 0.0
.symtab 421488 421488 0 0.0
.text 1542960 1542960 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1685932 1685932 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213289 1213289 0 0.0
.debug_aranges 111200 111200 0 0.0
.debug_frame 376044 376044 0 0.0
.debug_info 26451904 26451904 0 0.0
.debug_line 3677896 3677896 0 0.0
.debug_loc 3560700 3560700 0 0.0
.debug_ranges 337040 337040 0 0.0
.debug_str 3416401 3416401 0 0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535061 535061 0 0.0
.symtab 408080 408080 0 0.0
.text 1486896 1486896 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1603180 1603180 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048108 1048108 0 0.0
.debug_aranges 103376 103376 0 0.0
.debug_frame 346312 346312 0 0.0
.debug_info 21914186 21914186 0 0.0
.debug_line 3248361 3248361 0 0.0
.debug_loc 3259042 3259042 0 0.0
.debug_ranges 302512 302512 0 0.0
.debug_str 3221667 3221667 0 0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468360 468360 0 0.0
.symtab 375168 375168 0 0.0
.text 1412376 1412376 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640876 1640876 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1055543 1055543 0 0.0
.debug_aranges 104048 104048 0 0.0
.debug_frame 349140 349140 0 0.0
.debug_info 22293933 22293932 -1 -0.0
.debug_line 3257182 3257182 0 0.0
.debug_loc 3298895 3298895 0 0.0
.debug_ranges 305856 305856 0 0.0
.debug_str 3249088 3249088 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474563 474563 0 0.0
.symtab 378352 378352 0 0.0
.text 1445040 1445040 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129140 1129148 8 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 576236 576244 8 0.0
lock-app qpg6105+debug (read/write) 1100160 1100160 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 547260 547260 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808972 808972 0 0.0
bss 71344 71344 0 0.0
noinit 43488 43488 0 0.0
text 571452 571450 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 830888 830888 0 0.0
bss 72200 72200 0 0.0
noinit 43488 43488 0 0.0
text 589576 589576 0 0.0

andy31415 added a commit to andy31415/connectedhomeip that referenced this pull request Sep 9, 2022
@andy31415
Fix android compilation: missing cast when formatting value in string (…
9a4a317 
…project-chip#22382)

* Fix android compilation: missing cast when formatting value in string

* Restyle
@andy31415 andy31415 mentioned this pull request Sep 9, 2022
Merged
andy31415 added a commit that referenced this pull request Sep 9, 2022
@andy31415
Fix android compilation: missing cast when formatting value in string (…
fff6c23 
…#22382) (#22522)

* Fix android compilation: missing cast when formatting value in string

* Restyle
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@andy31415 @isiu-apple
Fix android compilation: missing cast when formatting value in string (…
db0bbbf 
…project-chip#22382)

* Fix android compilation: missing cast when formatting value in string

* Restyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

Assignees
No one assigned
Labels
examples hotfix urgent fix needed, can bypass review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy31415 @bzbarsky-apple