-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tokenized tracing overrides into light-app specific GNI #17278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
added
hotfix
urgent fix needed, can bypass review
and removed
hotfix
urgent fix needed, can bypass review
labels
Apr 12, 2022
tcarmelveilleux
approved these changes
Apr 12, 2022
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
msandstedt,
sagar-apple and
saurabhst
April 12, 2022 14:15
pullapprove
bot
requested review from
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
April 12, 2022 14:15
PR #17278: Size comparison from 3faca7e to ba7c4ce Full report (19 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
changed the title
Move tokenized tracing overrides into its own GNI
Move tokenized tracing overrides into light-app specific GNI
Apr 12, 2022
mspang
approved these changes
Apr 12, 2022
PR #17278: Size comparison from 2c15978 to 667b016 Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
fast tracking: this fixes a build breakage |
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…-chip#17278) * Move tokenized tracing oveffides into its own GNI * Updated logic: moved backed to light-specific file * Revert unintended change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
EFR lock app with RPC fails to compile after #17254:
It looks like pw_rpc.gni overrides automatically assumes that tracing is used, which is not the case on all apps and generally is not a requirement.
Change overview
set pw_tracing backend in the light app only rather than for all RPCs. Tracing usage depends on app config.
Testing
Locally compiled rpc variants for both light and lock