WindowCovering: fixes + simplification #16841

jmeg-sfy · 2022-03-30T17:21:52Z

Problem

What is being fixed? Examples:

Fix [SQA] TC-WNCV-4.1 windowcovering read target-position-lift-percent100ths value mismatches #16817
Fix Window covering cluster [TC-WNCV-4.2] - Target-position-tilt-percent100ths value is mismatched with the expected outcome #16626
Fix [TE8][TC_WNCV_4.3 4.4] #16396
Fix [TE8][TC_WNCV_4_1] Chip-Tool truncates 100th data #16167
Fix Windowcovering testcase [TC-WNCV-4.5] - Result is not matched with the expected outcome #16007
All those are related to Current -> not equals target
or GoTos not using the right parameter

Change overview

We do 3 fixes

EFR32 remove overwriting of current positions val at preset
EFR32 fix Current == Target at the end of motion
ALL: GoTos are fixed with the right input param

Otherwise there are some factorization to simplify the code a bit
for the EFR32 Demo

Testing

How was this tested? (at least one bullet point required)

Tested on EFR32 window-app demo
Passing the current CI-TestCases associated with All-cluster-app
Sadly for the moment WNCV test cannot catch issue on EFR32

github-actions · 2022-03-30T17:57:36Z

PR #16841: Size comparison from 0d98cc2 to 5ee682c

Increases (6 builds for esp32, linux, nrfconnect, p6)

platform	target	config	section	`0d98cc2`	`5ee682c`	change	% change
esp32	all-clusters-app	c3devkit	(read only)	969434	970120	686	0.1
			(read/write)	1394882	1394954	72	0.0
			.flash.rodata	199320	199392	72	0.0
			.flash.text	969434	970120	686	0.1
		m5stack	(read only)	1025047	1025667	620	0.1
			(read/write)	462636	462700	64	0.0
			.flash.rodata	228832	228896	64	0.0
			.flash.text	`1019663`	1020283	620	0.1
linux	all-clusters-app	debug	(read only)	2544289	`2546177`	1888	0.1
			.rodata	217125	217189	64	0.0
			.text	`2163266`	2165090	1824	0.1
	shell	debug	(read only)	2457393	2459313	1920	0.1
			.rodata	210290	210386	96	0.0
			.text	`2090082`	2091906	1824	0.1
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1146395	`1147039`	644	0.1
			rodata	142660	142728	68	0.0
			text	785832	786408	576	0.1
p6	all-clusters-app	default	(read/write)	2501304	2501856	552	0.0
			.text	1459568	1460120	552	0.0

Decreases (1 build for efr32)

platform	target	config	section	`0d98cc2`	`5ee682c`	change	% change
efr32	window-app	BRD4161A	(read only)	858976	858936	-40	-0.0
			.text	858968	858928	-40	-0.0

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)

platform	target	config	section	`0d98cc2`	`5ee682c`	change	% change
cyw30739	light	cyw930739m2evb_01	(read/write)	608546	608546	0	0.0
			.app_xip_area	515312	515312	0	0.0
			.bss	75980	75980	0	0.0
			.data	604	604	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	lock	cyw930739m2evb_01	(read/write)	566086	566086	0	0.0
			.app_xip_area	474380	474380	0	0.0
			.bss	74484	74484	0	0.0
			.data	568	568	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	578170	578170	0	0.0
			.app_xip_area	476808	476808	0	0.0
			.bss	83820	83820	0	0.0
			.data	508	508	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
efr32	lighting-app	BRD4161A	(read only)	929492	929492	0	0.0
			(read/write)	129108	129108	0	0.0
			.bss	127112	127112	0	0.0
			.data	1996	1996	0	0.0
			.text	929484	929484	0	0.0
		BRD4161A+rpc	(read only)	958500	958500	0	0.0
			(read/write)	145072	145072	0	0.0
			.bss	142896	142896	0	0.0
			.data	2176	2176	0	0.0
			.text	958492	958492	0	0.0
	window-app	BRD4161A	(read only)	858976	858936	-40	-0.0
			(read/write)	127072	127072	0	0.0
			.bss	125200	125200	0	0.0
			.data	1872	1872	0	0.0
			.text	858968	858928	-40	-0.0
esp32	all-clusters-app	c3devkit	(read only)	969434	970120	686	0.1
			(read/write)	1394882	1394954	72	0.0
			.dram0.bss	62416	62416	0	0.0
			.dram0.data	14228	14228	0	0.0
			.flash.rodata	199320	199392	72	0.0
			.flash.text	969434	970120	686	0.1
			.iram0.text	62016	62016	0	0.0
		m5stack	(read only)	1025047	1025667	620	0.1
			(read/write)	462636	462700	64	0.0
			.dram0.bss	67944	67944	0	0.0
			.dram0.data	34024	34024	0	0.0
			.flash.rodata	228832	228896	64	0.0
			.flash.text	`1019663`	1020283	620	0.1
			.iram0.text	123107	123107	0	0.0
k32w	light	k32w061+release	(read/write)	706992	706992	0	0.0
			.bss	77976	77976	0	0.0
			.data	1876	1876	0	0.0
			.text	621340	621340	0	0.0
	lock	k32w061+release	(read/write)	706100	706100	0	0.0
			.bss	77944	77944	0	0.0
			.data	1916	1916	0	0.0
			.text	620440	620440	0	0.0
linux	all-clusters-app	debug	(read only)	2544289	`2546177`	1888	0.1
			(read/write)	143384	143384	0	0.0
			.bss	57408	57408	0	0.0
			.data	1280	1280	0	0.0
			.data.rel.ro	78952	78952	0	0.0
			.dynamic	592	592	0	0.0
			.got	4184	4184	0	0.0
			.init	27	27	0	0.0
			.init_array	944	944	0	0.0
			.rodata	217125	217189	64	0.0
			.text	`2163266`	2165090	1824	0.1
	bridge-app	debug+rpc	(read only)	`1776405`	`1776405`	0	0.0
			(read/write)	89552	89552	0	0.0
			.bss	44520	44520	0	0.0
			.data	1984	1984	0	0.0
			.data.rel.ro	37968	37968	0	0.0
			.dynamic	592	592	0	0.0
			.got	3928	3928	0	0.0
			.init	27	27	0	0.0
			.init_array	544	544	0	0.0
			.rodata	145228	145228	0	0.0
			.text	1515749	1515749	0	0.0
	chip-tool	debug	(read only)	10321845	10321845	0	0.0
			(read/write)	356784	356784	0	0.0
			.bss	22528	22528	0	0.0
			.data	1072	1072	0	0.0
			.data.rel.ro	327000	327000	0	0.0
			.dynamic	624	624	0	0.0
			.got	4872	4872	0	0.0
			.init	27	27	0	0.0
			.init_array	648	648	0	0.0
			.rodata	526837	526837	0	0.0
			.text	9007621	9007621	0	0.0
	chip-tool-no-interactive-ipv6only	arm64	(read only)	9930612	9930612	0	0.0
			(read/write)	475665	475665	0	0.0
			.bss	40769	40769	0	0.0
			.data	1144	1144	0	0.0
			.data.rel.ro	373712	373712	0	0.0
			.dynamic	560	560	0	0.0
			.got	56232	56232	0	0.0
			.init	24	24	0	0.0
			.init_array	192	192	0	0.0
			.rodata	501468	501468	0	0.0
			.text	8371124	8371124	0	0.0
	door-lock-app	debug	(read only)	2029081	2029081	0	0.0
			(read/write)	116928	116928	0	0.0
			.bss	47648	47648	0	0.0
			.data	992	992	0	0.0
			.data.rel.ro	62872	62872	0	0.0
			.dynamic	592	592	0	0.0
			.got	4128	4128	0	0.0
			.init	27	27	0	0.0
			.init_array	664	664	0	0.0
			.rodata	181852	181852	0	0.0
			.text	1697346	1697346	0	0.0
	lighting-app	debug+rpc	(read only)	2206777	2206777	0	0.0
			(read/write)	123888	123888	0	0.0
			.bss	48928	48928	0	0.0
			.data	1472	1472	0	0.0
			.data.rel.ro	67944	67944	0	0.0
			.dynamic	608	608	0	0.0
			.got	4176	4176	0	0.0
			.init	27	27	0	0.0
			.init_array	744	744	0	0.0
			.rodata	175804	175804	0	0.0
			.text	`1871730`	`1871730`	0	0.0
	ota-provider-app	debug	(read only)	`1969145`	`1969145`	0	0.0
			(read/write)	112720	112720	0	0.0
			.bss	47584	47584	0	0.0
			.data	1256	1256	0	0.0
			.data.rel.ro	58216	58216	0	0.0
			.dynamic	608	608	0	0.0
			.got	4384	4384	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	167571	167571	0	0.0
			.text	`1649634`	`1649634`	0	0.0
	ota-requestor-app	debug	(read only)	1996641	1996641	0	0.0
			(read/write)	115944	115944	0	0.0
			.bss	48512	48512	0	0.0
			.data	1480	1480	0	0.0
			.data.rel.ro	60472	60472	0	0.0
			.dynamic	592	592	0	0.0
			.got	4192	4192	0	0.0
			.init	27	27	0	0.0
			.init_array	640	640	0	0.0
			.rodata	163756	163756	0	0.0
			.text	`1679938`	`1679938`	0	0.0
	shell	debug	(read only)	2457393	2459313	1920	0.1
			(read/write)	147400	147400	0	0.0
			.bss	67304	67304	0	0.0
			.data	800	800	0	0.0
			.data.rel.ro	73592	73592	0	0.0
			.dynamic	592	592	0	0.0
			.got	4160	4160	0	0.0
			.init	27	27	0	0.0
			.init_array	920	920	0	0.0
			.rodata	210290	210386	96	0.0
			.text	`2090082`	2091906	1824	0.1
	thermostat-no-ble	arm64	(read only)	2286396	2286396	0	0.0
			(read/write)	148401	148401	0	0.0
			.bss	62817	62817	0	0.0
			.data	1040	1040	0	0.0
			.data.rel.ro	77000	77000	0	0.0
			.dynamic	560	560	0	0.0
			.got	4528	4528	0	0.0
			.init	24	24	0	0.0
			.init_array	360	360	0	0.0
			.rodata	140220	140220	0	0.0
			.text	`1922688`	`1922688`	0	0.0
	tv-app	debug	(read only)	2705225	2705225	0	0.0
			(read/write)	247552	247552	0	0.0
			.bss	164288	164288	0	0.0
			.data	3136	3136	0	0.0
			.data.rel.ro	74064	74064	0	0.0
			.dynamic	592	592	0	0.0
			.got	4552	4552	0	0.0
			.init	27	27	0	0.0
			.init_array	888	888	0	0.0
			.rodata	206635	206635	0	0.0
			.text	2323890	2323890	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2358308	2358308	0	0.0
			.bss	185020	185020	0	0.0
			.data	5760	5760	0	0.0
			.text	`1320908`	`1320908`	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1146395	`1147039`	644	0.1
			bss	143056	143056	0	0.0
			rodata	142660	142728	68	0.0
			text	785832	786408	576	0.1
p6	all-clusters-app	default	(read/write)	2501304	2501856	552	0.0
			.bss	118440	118440	0	0.0
			.data	2640	2640	0	0.0
			.text	1459568	1460120	552	0.0
	light-app	default	(read/write)	2403464	2403464	0	0.0
			.bss	111912	111912	0	0.0
			.data	2496	2496	0	0.0
			.text	1361728	1361728	0	0.0
	lock-app	default	(read/write)	`2367088`	`2367088`	0	0.0
			.bss	111656	111656	0	0.0
			.data	2456	2456	0	0.0
			.text	1325352	1325352	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	790812	790812	0	0.0
			bss	70272	70272	0	0.0
			noinit	40416	40416	0	0.0
			text	560818	560818	0	0.0

* DEV: Add ComputePercent100thsStep function to server * DEV: Simplify/Factorize OperationalStatus Scheduling update * Fix: Compilator ask for cast * Fix: Bug with GoTos wrong parameter * DEV: App possibility to SetNull to all Position attributes * DEV: Factorize SchedulePositionSet for Tilt/Lift * FIX: Bug where all attribute weren't updated properly * FIX: Missing prototype updates * DEV: Simplify/Factorize Up and Down for Tilt/Lift * DEV: Add Small comments about NVM * Restyled by clang-format * Fix: Conversion mistake lift tilt Co-authored-by: Restyled.io <commits@restyled.io>

jmeg-sfy added 10 commits March 30, 2022 19:07

DEV: Add ComputePercent100thsStep function to server

669c306

DEV: Simplify/Factorize OperationalStatus Scheduling update

8da4375

Fix: Compilator ask for cast

ae7b69f

Fix: Bug with GoTos wrong parameter

dd1fda2

DEV: App possibility to SetNull to all Position attributes

5cd6479

DEV: Factorize SchedulePositionSet for Tilt/Lift

7498fa9

FIX: Bug where all attribute weren't updated properly

239ef7d

FIX: Missing prototype updates

f2314f4

DEV: Simplify/Factorize Up and Down for Tilt/Lift

4b4fb9a

DEV: Add Small comments about NVM

ca78294

boring-cyborg bot added app examples labels Mar 30, 2022

pullapprove bot requested review from anush-apple, Byungjoo-Lee, bzbarsky-apple, carol-apple, cecille, chrisdecenzo, chshu, chulspro, Damian-Nordic, dhrishi, electrocucaracha, emargolis, franck-apple, gjc13, harimau-qirex, hawk248 and holbrookt March 30, 2022 17:22

pullapprove bot requested review from saurabhst, selissia, tecimovic, tcarmelveilleux, turon, vijs, vivien-apple, wbschiller, woody-apple and xylophone21 March 30, 2022 17:22

Restyled by clang-format

12d4032

pullapprove bot requested a review from xylophone21 March 30, 2022 17:22

pullapprove bot added the review - pending label Mar 30, 2022

restyled-io bot mentioned this pull request Mar 30, 2022

Restyle WindowCovering: fixes + simplification #16842

Closed

Fix: Conversion mistake lift tilt

5ee682c

jmartinez-silabs approved these changes Mar 30, 2022

View reviewed changes

bzbarsky-apple approved these changes Mar 31, 2022

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Mar 31, 2022

bzbarsky-apple merged commit 98294c9 into project-chip:master Mar 31, 2022

jmeg-sfy deleted the jmeg-sfy/window-covering-fixes branch March 31, 2022 07:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WindowCovering: fixes + simplification #16841

WindowCovering: fixes + simplification #16841

jmeg-sfy commented Mar 30, 2022

github-actions bot commented Mar 30, 2022 •

edited

Loading

WindowCovering: fixes + simplification #16841

WindowCovering: fixes + simplification #16841

Conversation

jmeg-sfy commented Mar 30, 2022

Problem

Change overview

Testing

github-actions bot commented Mar 30, 2022 • edited Loading

github-actions bot commented Mar 30, 2022 •

edited

Loading