-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WindowCovering: fixes + simplification #16841
Merged
bzbarsky-apple
merged 12 commits into
project-chip:master
from
jmeg-sfy:jmeg-sfy/window-covering-fixes
Mar 31, 2022
Merged
WindowCovering: fixes + simplification #16841
bzbarsky-apple
merged 12 commits into
project-chip:master
from
jmeg-sfy:jmeg-sfy/window-covering-fixes
Mar 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248 and
holbrookt
March 30, 2022 17:22
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
tcarmelveilleux,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
March 30, 2022 17:22
jmartinez-silabs
approved these changes
Mar 30, 2022
PR #16841: Size comparison from 0d98cc2 to 5ee682c Increases (6 builds for esp32, linux, nrfconnect, p6)
Decreases (1 build for efr32)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 31, 2022
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
* DEV: Add ComputePercent100thsStep function to server * DEV: Simplify/Factorize OperationalStatus Scheduling update * Fix: Compilator ask for cast * Fix: Bug with GoTos wrong parameter * DEV: App possibility to SetNull to all Position attributes * DEV: Factorize SchedulePositionSet for Tilt/Lift * FIX: Bug where all attribute weren't updated properly * FIX: Missing prototype updates * DEV: Simplify/Factorize Up and Down for Tilt/Lift * DEV: Add Small comments about NVM * Restyled by clang-format * Fix: Conversion mistake lift tilt Co-authored-by: Restyled.io <commits@restyled.io>
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* DEV: Add ComputePercent100thsStep function to server * DEV: Simplify/Factorize OperationalStatus Scheduling update * Fix: Compilator ask for cast * Fix: Bug with GoTos wrong parameter * DEV: App possibility to SetNull to all Position attributes * DEV: Factorize SchedulePositionSet for Tilt/Lift * FIX: Bug where all attribute weren't updated properly * FIX: Missing prototype updates * DEV: Simplify/Factorize Up and Down for Tilt/Lift * DEV: Add Small comments about NVM * Restyled by clang-format * Fix: Conversion mistake lift tilt Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
We do 3 fixes
Otherwise there are some factorization to simplify the code a bit
for the EFR32 Demo
Testing
How was this tested? (at least one bullet point required)