Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nRF5 lock app build instructions #1572

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Fix nRF5 lock app build instructions #1572

merged 1 commit into from
Jul 13, 2020

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Jul 11, 2020

After 52b6f03 ("[gn] Vscode integration. Fixes #1526. (#1527)")
the args are missing due to being set later in the script. Rearrange
so the correct comment is printed.

@mspang
Fix nRF5 lock app build instructions
85f9c91 
After 52b6f03 ("[gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)")
the args are missing due to being set later in the script. Rearrange
so the correct comment is printed.
@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@andy31415 andy31415 merged commit f305152 into project-chip:master Jul 13, 2020
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
@mspang @kedars
Fix nRF5 lock app build instructions (project-chip#1572)
68ae230 
After 52b6f03 ("[gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)")
the args are missing due to being set later in the script. Rearrange
so the correct comment is printed.
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
@mspang @kedars
Fix nRF5 lock app build instructions (project-chip#1572)
e7166ab 
After 52b6f03 ("[gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)")
the args are missing due to being set later in the script. Rearrange
so the correct comment is printed.
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
@mspang @kedars
Fix nRF5 lock app build instructions (project-chip#1572)
7b00302 
After 52b6f03 ("[gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)")
the args are missing due to being set later in the script. Rearrange
so the correct comment is printed.
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
@mspang @kedars
Fix nRF5 lock app build instructions (project-chip#1572)
5144d8f 
After 52b6f03 ("[gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)")
the args are missing due to being set later in the script. Rearrange
so the correct comment is printed.
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
@mspang @kedars
Fix nRF5 lock app build instructions (project-chip#1572)
783dcfe 
After 52b6f03 ("[gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)")
the args are missing due to being set later in the script. Rearrange
so the correct comment is printed.
@mspang mspang deleted the for-chip/script-hints branch August 14, 2020 20:17
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request May 8, 2024
@Thirsrin @jmartinez-silabs
Pull request project-chip#1572: NoJira: Unify Docker build fix
56bb9c8 
Merge in WMN_TOOLS/matter from bugfix/docker_build_fix to silabs

Squashed commit of the following:

commit 312994abc83b6aa8573e688460995224fdda6bb1
Author: thirupathi <ths@silabs.com>
Date:   Fri Feb 16 11:54:56 2024 +0530

    update the docker image in artifactory and update jenkinsfile to use the latest docker image

commit 78a84fa005e40e6709dc1798011dbe44c46bc869
Author: thirupathi <ths@silabs.com>
Date:   Fri Feb 16 10:39:11 2024 +0530

    Docker build fix
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@Thirsrin @jmartinez-silabs
Pull request project-chip#1572: NoJira: Unify Docker build fix
2e9f334 
Merge in WMN_TOOLS/matter from bugfix/docker_build_fix to silabs

Squashed commit of the following:

commit 312994abc83b6aa8573e688460995224fdda6bb1
Author: thirupathi <ths@silabs.com>
Date:   Fri Feb 16 11:54:56 2024 +0530

    update the docker image in artifactory and update jenkinsfile to use the latest docker image

commit 78a84fa005e40e6709dc1798011dbe44c46bc869
Author: thirupathi <ths@silabs.com>
Date:   Fri Feb 16 10:39:11 2024 +0530

    Docker build fix
chirag-silabs pushed a commit to rosahay-silabs/connectedhomeip that referenced this pull request Jul 15, 2024
@Thirsrin @jmartinez-silabs
Pull request project-chip#1572: NoJira: Unify Docker build fix
87e178d 
Merge in WMN_TOOLS/matter from bugfix/docker_build_fix to silabs

Squashed commit of the following:

commit 312994abc83b6aa8573e688460995224fdda6bb1
Author: thirupathi <ths@silabs.com>
Date:   Fri Feb 16 11:54:56 2024 +0530

    update the docker image in artifactory and update jenkinsfile to use the latest docker image

commit 78a84fa005e40e6709dc1798011dbe44c46bc869
Author: thirupathi <ths@silabs.com>
Date:   Fri Feb 16 10:39:11 2024 +0530

    Docker build fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turon turon turon approved these changes

@andy31415 andy31415 andy31415 approved these changes

@saurabhst saurabhst saurabhst approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GN build parity - VSCode integration
5 participants
@mspang @turon @andy31415 @saurabhst @woody-apple