Add linux embedded & standalone examples to GN build + misc cleanups #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This separates platform default args from app specific args.
This file includes common definitions for the device layer, so move it there.
- Move build_overrides and symlink it so we can share it between examples - Remove build_overrides/nrf5_lock_app.gni; the samples can use relative paths to their own files and $chip_root to reference chip files. - Remove the split args file and instead put the 2 special args directly in .gn
Simplify some code copy pasted from pigweed & remove dead code.
Define a new toolchain for config/standalone to build these examples.
mspang
requested review from
andy31415,
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
andy31415
approved these changes
Jul 9, 2020
BroderickCarlin
approved these changes
Jul 9, 2020
woody-apple
approved these changes
Jul 10, 2020
|
@mspang merge conflict here! |
@woody-apple done |
jmartinez-silabs
added a commit
to SiliconLabs/matter
that referenced
this pull request
Feb 15, 2024
…ReaderConfig and ClearAliroReaderConfig commands (project-chip#31700) Merge in WMN_TOOLS/matter from cherry-pick/dl_aliro to RC_2.3.0-1.3 Squashed commit of the following: commit 471bcc1d95bc35bb13a7e02e481d81ec9e4f00d7 Author: Nivi Sarkar <55898241+nivi-apple@users.noreply.github.com> Date: Tue Jan 30 16:37:46 2024 -0800 Add handling for SetAliroReaderConfig and ClearAliroReaderConfig commands (project-chip#31700) * Add handling for SetAliroReaderConfig and ClearAliroReaderConfig commands Add a delegate for the door lock to provide the attribute data for the aliro attributes * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Address review comments * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Addressed more review comments * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Add an AttributeNullabilityType enum instead of boolean to indicate if an attribute is nullable or not * Restyled by clang-format * Make AttributeNullabilityType enum private --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Restyled.io <commits@restyled.io>
rcasallas-silabs
pushed a commit
to rcasallas-silabs/connectedhomeip
that referenced
this pull request
Jun 20, 2024
…ReaderConfig and ClearAliroReaderConfig commands (project-chip#31700) Merge in WMN_TOOLS/matter from cherry-pick/dl_aliro to RC_2.3.0-1.3 Squashed commit of the following: commit 471bcc1d95bc35bb13a7e02e481d81ec9e4f00d7 Author: Nivi Sarkar <55898241+nivi-apple@users.noreply.github.com> Date: Tue Jan 30 16:37:46 2024 -0800 Add handling for SetAliroReaderConfig and ClearAliroReaderConfig commands (project-chip#31700) * Add handling for SetAliroReaderConfig and ClearAliroReaderConfig commands Add a delegate for the door lock to provide the attribute data for the aliro attributes * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Address review comments * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Addressed more review comments * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Add an AttributeNullabilityType enum instead of boolean to indicate if an attribute is nullable or not * Restyled by clang-format * Make AttributeNullabilityType enum private --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flesh out GN build more:
fixes #1511
fixes #1517