Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enumeration to CHIPTool and fix CHIPTool builds #14901

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

sagar-apple
Copy link
Contributor

Problem

We have no use for the Echo View controller anymore. We can replace it with something more useful.

Change overview

Added an Enumeration View Controller that tries to read the descriptor cluster on each endpoint and gather information about the accessory.

Testing

  • If manually tested, what platforms controller and device platforms were manually tested, and how?
    Manually tested that enumeration runs on the M5Stack via the CHIPTool iOS application

@woody-apple
Copy link
Contributor

Fast tracking test tool changes

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

PR #14901: Size comparison from 68b451e to 69c9cfd

Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 68b451e 69c9cfd change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595378 595378 0 0.0
.app_xip_area 500912 500912 0 0.0
.bss 77188 77188 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556330 556330 0 0.0
.app_xip_area 463400 463400 0 0.0
.bss 75684 75684 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577294 577294 0 0.0
.app_xip_area 475068 475068 0 0.0
.bss 84652 84652 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 866356 866356 0 0.0
(read/write) 126684 126684 0 0.0
.bss 124760 124760 0 0.0
.data 1924 1924 0 0.0
.text 866348 866348 0 0.0
BRD4161A+rpc (read only) 853804 853804 0 0.0
(read/write) 143344 143344 0 0.0
.bss 141320 141320 0 0.0
.data 2024 2024 0 0.0
.text 853796 853796 0 0.0
window-app BRD4161A (read only) 838560 838560 0 0.0
(read/write) 125328 125328 0 0.0
.bss 123448 123448 0 0.0
.data 1880 1880 0 0.0
.text 838552 838552 0 0.0
esp32 all-clusters-app c3devkit (read only) 939198 939198 0 0.0
(read/write) 1401874 1401874 0 0.0
.dram0.bss 70024 70024 0 0.0
.dram0.data 14260 14260 0 0.0
.flash.rodata 198680 198680 0 0.0
.flash.text 939198 939198 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 987351 987351 0 0.0
(read/write) 466892 466892 0 0.0
.dram0.bss 75160 75160 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 225580 225580 0 0.0
.flash.text 981967 981967 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679180 679180 0 0.0
.bss 76632 76632 0 0.0
.data 1884 1884 0 0.0
.text 594864 594864 0 0.0
lock k32w061+release (read/write) 683996 683996 0 0.0
.bss 76984 76984 0 0.0
.data 1928 1928 0 0.0
.text 599284 599284 0 0.0
linux all-clusters-app debug (read only) 2334457 2334457 0 0.0
(read/write) 140640 140640 0 0.0
.bss 55200 55200 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 78600 78600 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 204901 204901 0 0.0
.text 1967234 1967234 0 0.0
bridge-app debug+rpc (read only) 1705909 1705909 0 0.0
(read/write) 84328 84328 0 0.0
.bss 39088 39088 0 0.0
.data 1970 1970 0 0.0
.data.rel.ro 38120 38120 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 140332 140332 0 0.0
.text 1449029 1449029 0 0.0
chip-tool debug (read only) 7472989 7472989 0 0.0
(read/write) 197624 197624 0 0.0
.bss 32360 32360 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 158088 158088 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 414773 414773 0 0.0
.text 6656773 6656773 0 0.0
chip-tool-ipv6only arm64 (read only) 7393132 7393132 0 0.0
(read/write) 301857 301857 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 199792 199792 0 0.0
.dynamic 560 560 0 0.0
.got 46448 46448 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 397508 397508 0 0.0
.text 6357172 6357172 0 0.0
door-lock-app debug (read only) 1910633 1910633 0 0.0
(read/write) 110680 110680 0 0.0
.bss 42160 42160 0 0.0
.data 946 946 0 0.0
.data.rel.ro 62160 62160 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171858 171858 0 0.0
.text 1590258 1590258 0 0.0
lighting-app debug+rpc (read only) 2005177 2005177 0 0.0
(read/write) 115632 115632 0 0.0
.bss 43104 43104 0 0.0
.data 1368 1368 0 0.0
.data.rel.ro 65672 65672 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 163057 163057 0 0.0
.text 1687474 1687474 0 0.0
ota-provider-app debug (read only) 1714505 1714505 0 0.0
(read/write) 81368 81368 0 0.0
.bss 41120 41120 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 33560 33560 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151910 151910 0 0.0
.text 1443890 1443890 0 0.0
ota-requestor-app debug (read only) 1703161 1703161 0 0.0
(read/write) 83320 83320 0 0.0
.bss 42272 42272 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 34616 34616 0 0.0
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 145047 145047 0 0.0
.text 1441218 1441218 0 0.0
shell debug (read only) 2307929 2307929 0 0.0
(read/write) 142224 142224 0 0.0
.bss 62592 62592 0 0.0
.data 768 768 0 0.0
.data.rel.ro 73168 73168 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205650 205650 0 0.0
.text 1945762 1945762 0 0.0
thermostat-no-ble arm64 (read only) 2134876 2134876 0 0.0
(read/write) 141009 141009 0 0.0
.bss 57953 57953 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74952 74952 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 132316 132316 0 0.0
.text 1784400 1784400 0 0.0
tv-app debug (read only) 2521097 2521097 0 0.0
(read/write) 140056 140056 0 0.0
.bss 57568 57568 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73288 73288 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 196908 196908 0 0.0
.text 2150818 2150818 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2390960 2390960 0 0.0
.bss 188932 188932 0 0.0
.data 5288 5288 0 0.0
.text 1353560 1353560 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349448 2349448 0 0.0
.bss 181000 181000 0 0.0
.data 5600 5600 0 0.0
.text 1312048 1312048 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317408 2317408 0 0.0
.bss 180912 180912 0 0.0
.data 5584 5584 0 0.0
.text 1280008 1280008 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303340 2303340 0 0.0
.bss 178164 178164 0 0.0
.data 5400 5400 0 0.0
.text 1265912 1265912 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005423 1005423 0 0.0
bss 121344 121344 0 0.0
rodata 118268 118268 0 0.0
text 686928 686928 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 974379 974379 0 0.0
bss 118532 118532 0 0.0
rodata 109656 109656 0 0.0
text 666540 666540 0 0.0
nrf52840dongle_nrf52840 (read/write) 1022227 1022227 0 0.0
bss 122708 122708 0 0.0
rodata 117156 117156 0 0.0
text 692496 692496 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 912146 912146 0 0.0
bss 117904 117904 0 0.0
rodata 111524 111524 0 0.0
text 601952 601952 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 940615 940615 0 0.0
bss 119712 119712 0 0.0
rodata 107492 107492 0 0.0
text 634832 634832 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848078 848078 0 0.0
bss 116304 116304 0 0.0
rodata 100664 100664 0 0.0
text 550632 550632 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 940035 940035 0 0.0
bss 119432 119432 0 0.0
rodata 106848 106848 0 0.0
text 635088 635088 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 935375 935375 0 0.0
bss 119436 119436 0 0.0
rodata 106140 106140 0 0.0
text 631124 631124 0 0.0
shell nrf52840dk_nrf52840 (read/write) 803719 803719 0 0.0
bss 111296 111296 0 0.0
rodata 78668 78668 0 0.0
text 536128 536128 0 0.0
p6 all-clusters-app default (read/write) 2465504 2465504 0 0.0
.bss 118544 118544 0 0.0
.data 2568 2568 0 0.0
.text 1423768 1423768 0 0.0
light-app default (read/write) 2367760 2367760 0 0.0
.bss 107664 107664 0 0.0
.data 2432 2432 0 0.0
.text 1326024 1326024 0 0.0
lock-app default (read/write) 2336584 2336584 0 0.0
.bss 107400 107400 0 0.0
.data 2400 2400 0 0.0
.text 1294848 1294848 0 0.0
qpg lighting-app qpg6105+debug (read only) 586368 586368 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88920 88920 0 0.0
.data 1084 1084 0 0.0
.text 581048 581048 0 0.0
lock-app qpg6105+debug (read only) 535316 535316 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88392 88392 0 0.0
.data 1028 1028 0 0.0
.text 529996 529996 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 869974 869974 0 0.0
bss 88672 88672 0 0.0
noinit 37160 37160 0 0.0
text 611380 611380 0 0.0

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better with wildcard reads and whatnot, but this is fine for now.

@bzbarsky-apple bzbarsky-apple merged commit 02f7dab into project-chip:master Feb 8, 2022
@sagar-apple sagar-apple deleted the chipTool_walk branch February 8, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants