Set configuration manager #11534
Merged
Set configuration manager #11534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #11534: Size comparison from a93a7da to 8ba1e46 Increases above 0.2%:
Increases (20 builds for efr32, k32w, linux, p6, qpg, telink)
Decreases (12 builds for efr32, k32w, p6, qpg)
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda and
lzgrablic02
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
turon,
vivien-apple,
wbschiller and
woody-apple
|
PR #11534: Size comparison from a93a7da to 9570c77 Increases above 0.2%:
Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (20 builds for efr32, esp32, k32w, linux, mbed, p6, qpg)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
reviewed
Nov 8, 2021
woody-apple
approved these changes
Nov 9, 2021
Also remove the implementation getter.
Promote the reboot count, boot reason, and operational hours methods to the ConfigurationManager interface.
* Add VerifyOrDie to the ConfigurationMgr getter. * Pass a pointer rather than a reference to ConfigurationMgr. * Explicitly default the instance pointer to nullptr. * Move the singleton implementation out of each platform into a shared file.
harimau-qirex
force-pushed
the
set-configuration-manager
branch
from
2bd84ef
to
b7986bf
Compare
|
PR #11534: Size comparison from 89898f8 to 23d3b8f Increases above 0.2%:
Increases (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (16 builds for efr32, k32w, mbed, p6, qpg)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Nov 10, 2021
|
fast track: PR up for several days, has 2 approvals already. |
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* Add the setter for the ConfigurationManager. Also remove the implementation getter. * Remove uses of ConfigurationMgrImpl. Promote the reboot count, boot reason, and operational hours methods to the ConfigurationManager interface. * Add a static instance getter to the ConfigurationManagerImpl. * Set the default ConfigurationManager instance in the platform manager. * Update the tests to set a ConfigurationManager instance. * Allow subclasses of the platform ConfigurationManagerImpls. * Re-fix Ameba's ConfigurationManagerImpl. * Restyled by clang-format * Improvements from pull request comments. * Add VerifyOrDie to the ConfigurationMgr getter. * Pass a pointer rather than a reference to ConfigurationMgr. * Explicitly default the instance pointer to nullptr. * Move the singleton implementation out of each platform into a shared file. * Update Ameba platform to remove the new uses of ConfigurationMgrImpl. Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For applications and tests to use custom ConfigurationManagers (introduced by #10195), a mechanism is needed to set the implementation that the SDK uses. With this an application or test will be able to create and use a custom implementation that overrides as much or as little functionality as is required.
Change overview
Testing
Ran the unit tests.