Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the project-chip fork of shellcheck #100

Merged
merged 3 commits into from
Mar 24, 2020
Merged

Use the project-chip fork of shellcheck #100

merged 3 commits into from
Mar 24, 2020

Conversation

rwalker-apple
Copy link
Contributor

Problem

shellcheck doesn't support excluding directories that might be imports,
e.g in the chip repo, we don't audit third_party

Summary of Changes

  • take advantage of project-chip's fork of shellcheck
  • fix scripts that run afoul of the check

turon
turon reviewed Mar 24, 2020
View reviewed changes
integrations/clang/clang-format.sh
@@ -2,14 +2,15 @@

CLANG_FORMAT_VERSION="clang-format version 9.0"

# shellcheck disable=SC2120
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, at this point.

@woody-apple woody-apple merged commit ea7ddc0 into project-chip:master Mar 24, 2020
@rwalker-apple rwalker-apple deleted the fork-shellcheck branch March 24, 2020 18:54
fkjagodzinski pushed a commit to fkjagodzinski/connectedhomeip that referenced this pull request Mar 18, 2021
Mbed: Add timer and internal event queue to AppTask.cpp
9f66801 
Fixes: project-chip#100
Fixes: project-chip#103
mkardous-silabs referenced this pull request in SiliconLabs/watt-sandbox Oct 6, 2022
@silabsbot @mkardous-silabs
Pull request SiliconLabs#100: MATTER-724: add hwmux for Junit and boo…
0ddc357 
…tloader files

Merge in WMN_TOOLS/matter from bugfix/MATTER-724 to silabs

Squashed commit of the following:

commit ee0ca830a784fd13d2a7ef9d852ce4d733f56593
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Fri Sep 16 10:12:21 2022 -0400

    add try catch on nexus push stage

commit 807431f0b43c0f9fbf21ec225f232dd36898f9ae
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Tue Sep 13 18:49:33 2022 -0400

    add hwmux for Junit and bootloader files
nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this pull request Oct 19, 2022
@silabsbot @jmartinez-silabs
Pull request project-chip#100: MATTER-724: add hwmux for Junit and bo…
88aa1df 
…otloader files

Merge in WMN_TOOLS/matter from bugfix/MATTER-724 to silabs

Squashed commit of the following:

commit ee0ca830a784fd13d2a7ef9d852ce4d733f56593
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Fri Sep 16 10:12:21 2022 -0400

    add try catch on nexus push stage

commit 807431f0b43c0f9fbf21ec225f232dd36898f9ae
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Tue Sep 13 18:49:33 2022 -0400

    add hwmux for Junit and bootloader files
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Oct 24, 2022
@silabsbot @jmartinez-silabs
Pull request #100: MATTER-724: add hwmux for Junit and bootloader files
44396fc 
Merge in WMN_TOOLS/matter from bugfix/MATTER-724 to silabs

Squashed commit of the following:

commit ee0ca830a784fd13d2a7ef9d852ce4d733f56593
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Fri Sep 16 10:12:21 2022 -0400

    add try catch on nexus push stage

commit 807431f0b43c0f9fbf21ec225f232dd36898f9ae
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Tue Sep 13 18:49:33 2022 -0400

    add hwmux for Junit and bootloader files
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Nov 2, 2022
@silabsbot @jmartinez-silabs
Pull request #100: MATTER-724: add hwmux for Junit and bootloader files
e32c55f 
Merge in WMN_TOOLS/matter from bugfix/MATTER-724 to silabs

Squashed commit of the following:

commit ee0ca830a784fd13d2a7ef9d852ce4d733f56593
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Fri Sep 16 10:12:21 2022 -0400

    add try catch on nexus push stage

commit 807431f0b43c0f9fbf21ec225f232dd36898f9ae
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Tue Sep 13 18:49:33 2022 -0400

    add hwmux for Junit and bootloader files
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Oct 5, 2023
@silabsbot @jmartinez-silabs
Pull request project-chip#100: MATTER-724: add hwmux for Junit and bo…
0fb25da 
…otloader files

Merge in WMN_TOOLS/matter from bugfix/MATTER-724 to silabs

Squashed commit of the following:

commit ee0ca830a784fd13d2a7ef9d852ce4d733f56593
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Fri Sep 16 10:12:21 2022 -0400

    add try catch on nexus push stage

commit 807431f0b43c0f9fbf21ec225f232dd36898f9ae
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Tue Sep 13 18:49:33 2022 -0400

    add hwmux for Junit and bootloader files
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Jan 11, 2024
@silabsbot @jmartinez-silabs
Pull request project-chip#100: MATTER-724: add hwmux for Junit and bo…
23886d4 
…otloader files

Merge in WMN_TOOLS/matter from bugfix/MATTER-724 to silabs

Squashed commit of the following:

commit ee0ca830a784fd13d2a7ef9d852ce4d733f56593
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Fri Sep 16 10:12:21 2022 -0400

    add try catch on nexus push stage

commit 807431f0b43c0f9fbf21ec225f232dd36898f9ae
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Tue Sep 13 18:49:33 2022 -0400

    add hwmux for Junit and bootloader files
mykrupp pushed a commit to mykrupp/connectedhomeip that referenced this pull request Jul 18, 2024
@silabsbot @jmartinez-silabs
Pull request project-chip#100: MATTER-724: add hwmux for Junit and bo…
9c244e2 
…otloader files

Merge in WMN_TOOLS/matter from bugfix/MATTER-724 to silabs

Squashed commit of the following:

commit ee0ca830a784fd13d2a7ef9d852ce4d733f56593
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Fri Sep 16 10:12:21 2022 -0400

    add try catch on nexus push stage

commit 807431f0b43c0f9fbf21ec225f232dd36898f9ae
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Tue Sep 13 18:49:33 2022 -0400

    add hwmux for Junit and bootloader files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turon turon turon left review comments

@gerickson gerickson gerickson approved these changes

@BroderickCarlin BroderickCarlin BroderickCarlin approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@tpmanley tpmanley Awaiting requested review from tpmanley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rwalker-apple @turon @gerickson @BroderickCarlin @woody-apple