Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specific checks for root pub key and fabric id for compressed fabric ID match #9192

Open
pan-apple opened this issue Aug 23, 2021 · 1 comment
Open

Add specific checks for root pub key and fabric id for compressed fabric ID match #9192

pan-apple opened this issue Aug 23, 2021 · 1 comment
Labels
security v1.1

Comments

@pan-apple
Copy link
Contributor

Problem

The current code compares the compressed fabric ID value itself to match two PeerId objects. This is error prone, as there could be a collision in values of compressed fabric ID for two different sets of Fabric ID + Root pub key combinations.

Proposed Solution

Carry raw fabric ID and root pub key in PeerId and compare these values for matching two PeerId objects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
security v1.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andy31415 @lzgrablic02 @woody-apple @pan-apple