Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestWriteInteraction should not be calling ProcessWriteResponseMessage directly #8258

Open
bzbarsky-apple opened this issue Jul 9, 2021 · 3 comments
Open

TestWriteInteraction should not be calling ProcessWriteResponseMessage directly #8258

bzbarsky-apple opened this issue Jul 9, 2021 · 3 comments
Assignees
@yunhanw-google
Labels
Interaction Model Work V1.X

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

TestWriteInteraction calls private ProcessWriteResponseMessage instead of the public OnMessageReceived entrypoint on WriteClient, which means that it doesn't test lifetime handling correctly.

Proposed Solution

Fix the test to call OnMessageReceived, not ProcessWriteResponseMessage.

This was missed in #7795
@bzbarsky-apple bzbarsky-apple mentioned this issue Jul 9, 2021
Closed
24 tasks
@stale
Copy link

stale bot commented Aug 14, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Aug 14, 2022
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Aug 26, 2022
@stale
Copy link

stale bot commented Mar 11, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Mar 11, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Mar 13, 2023
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 15, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yunhanw-google yunhanw-google

Labels
Interaction Model Work V1.X
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yunhanw-google @woody-apple @bzbarsky-apple