Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the missing part of Exchange Header in Transport layer #4016

Closed
yufengwangca opened this issue Nov 30, 2020 · 1 comment · Fixed by #4017
Closed

Implement the missing part of Exchange Header in Transport layer #4016

yufengwangca opened this issue Nov 30, 2020 · 1 comment · Fixed by #4017
Assignees

Comments

@yufengwangca
Copy link
Contributor

Problem

Currently, only I Flag (A single bit field indicating that the message was sent by the initiator of the exchange) is implemented in transport layer. Vendor Id is implemented in the Payload part but its flag is implemented in the Packet part, this cause, the payload header need to be passed through the transport stack.

Proposed Solution

  1. Add support for the following two flags in Exchange Header (8 bits)

A Flag (1 bit, position 1)
A single bit field indicating that the message serves as an acknowledgement of a previous message
received by the current message sender.

R Flag (1 bit, position 2)
A single bit field indicating that the message sender wishes to receive an acknowledgement for the
message.

  1. Move V flag from Packet Header to Payload Header

V Flag (1 bit, position 4)
A single bit field indicating whether a Vendor Id is prepended to the Message Protocol Id field.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.87. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant