Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the ServiceArea XML with a number of small changes since 0.7 #34670

Closed
hicklin opened this issue Jul 31, 2024 · 1 comment · Fixed by #34738
Closed

Update the ServiceArea XML with a number of small changes since 0.7 #34670

hicklin opened this issue Jul 31, 2024 · 1 comment · Fixed by #34738
Assignees
@hicklin

Comments

@hicklin
Copy link
Contributor

hicklin commented Jul 31, 2024 •
edited
Loading

Update the Service Area cluster's XML, and any necessary SDK code, to match the latest spec changes since 0.7. These spec changes address multiple spec issues and are addressed in a couple of spec PRs. Below is a summary of the spec issues and changes that this issue needs addressing.

  • Remove the LISTORDER feature as discussed in this issue and implemented in this PR.
  • Add the SkippedArea argument to the SkipArea command as discussed in this issue and implemented in this PR.
  • Add the LandmarkInfoStruct type and update the AreaInfoStruct as discussed in this issue and implemented in this PR.
  • Change the MapId type to uint32 as discussed in this issue and implemented in this PR.
  • Add the PROG feature as discussed in this issue and implemented in this PR.
  • Add the MAPS feature as discussed in this issue and implemented in this PR.
  • Removed the SurfaceTag as discussed in this issue and implemented in this PR.
  • Ensure that the final XML matches the latest spec.
@hicklin hicklin self-assigned this Jul 31, 2024
@hicklin
Copy link
Contributor Author

hicklin commented Aug 1, 2024

Fix this issue in the same PR.

This was referenced Aug 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hicklin hicklin

Labels
None yet
Projects
[Device Type] Robot Vacuums
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update service area xml from 07 dysonltd/connectedhomeip
1 participant
@hicklin