Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new IM status should come from a central source of truth, instead of needing to modify 4+ files #30927

Open
tehampson opened this issue Dec 11, 2023 · 1 comment
Open

Adding new IM status should come from a central source of truth, instead of needing to modify 4+ files #30927

tehampson opened this issue Dec 11, 2023 · 1 comment
Labels
Interaction Model Work

Comments

@tehampson
Copy link
Contributor

Problem:

  • When adding new IM status, as was done in Add new IM Status NO_COMMAND_RESPONSE #30921, you need to modify multiple files. It would be much better if you only need to modify one source of truth
    • af-enums.h's IM statuses should be easy to do and should just use macros from a different file.
@tehampson tehampson mentioned this issue Dec 11, 2023
Merged
@bzbarsky-apple
Copy link
Contributor

Ideally, the statuses in af-enums.h would just go away in favor of Status....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Interaction Model Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tehampson @bzbarsky-apple