Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laundry Mode spec cluster is called Laundry Washer Mode #30403

Closed
tcarmelveilleux opened this issue Nov 9, 2023 · 0 comments · Fixed by #30933
Closed

Laundry Mode spec cluster is called Laundry Washer Mode #30403

tcarmelveilleux opened this issue Nov 9, 2023 · 0 comments · Fixed by #30933
Labels
appliances Stuff related to appliance types and clusters laundry mode select Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation
Milestone
1.3 Feature Complete

Comments

@tcarmelveilleux
Copy link
Contributor

The Spec has "Laundry Mode" (cluster 0x0051) after a rename in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7446/files#diff-504af434eb626f56d80ce9a022f914da885003e76dd79e31cbcbf808da8b5ee2, while the SDK in 1.2 had "Laundry Washer Mode".

Now SDK has both Laundry Mode XML and Laundry Washer Mode XML, but only Laundry Washer Mode is used, and all code generated in 1.2 tag was using Laundry Washer Mode as before. The "Laundry Mode" actually did not carry through.

image

It is unclear what has to be done to resolve the inconsistency.
@tcarmelveilleux tcarmelveilleux added spec Mismatch between spec and implementation Spec XML align SDK XML does not match the spec (including naming, etc) laundry mode select appliances Stuff related to appliance types and clusters labels Nov 9, 2023
@tcarmelveilleux tcarmelveilleux added this to the 1.3 Feature Complete milestone Nov 9, 2023
@marktrayer marktrayer removed their assignment Dec 21, 2023
@marktrayer marktrayer mentioned this issue Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
appliances Stuff related to appliance types and clusters laundry mode select Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation
Projects
[1.3] SDK Feature Complete
Archived in project
[Device Type] Laundry Dryers
Archived in project
[Device Type] Laundry Washers
Archived in project
[Enhancements] Spec/XML Alignment
Archived in project
[Group] Appliances
Archived in project
Milestone
1.3 Feature Complete
Development

Successfully merging a pull request may close this issue.

Removing references to Laundry Mode back to Laundry Washer Mode abeck-whirlpool/connectedhomeip
2 participants
@tcarmelveilleux @marktrayer