Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] BooleanState cluster needs a cluster implementation #25225

Open
andy31415 opened this issue Feb 21, 2023 · 2 comments
Open

[Feature] BooleanState cluster needs a cluster implementation #25225

andy31415 opened this issue Feb 21, 2023 · 2 comments
Labels
app-clusters Application cluster work spec Mismatch between spec and implementation

Comments

@andy31415
Copy link
Contributor

Feature description

Current implementation available in the contact-sensor example just toggles the attribute store directly.

We generally want cluster implementation to expose some form of HAL to expose a mutation api instad of using the attribute storage directly, so that cluster behaviors can be controlled (e.g. use different storage logic or trigger additional behavior and checks).

Platform

all

Platform Version(s)

No response

Anything else?

No response
@andy31415 andy31415 mentioned this issue Feb 21, 2023
Merged
@bzbarsky-apple bzbarsky-apple added spec Mismatch between spec and implementation app-clusters Application cluster work labels Feb 21, 2023
@bzbarsky-apple
Copy link
Contributor

In particular, Boolean State needs to emit events as needed, if those are supported....

@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 15, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Oct 16, 2023
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue Jan 28, 2024
@tcarmelveilleux
[WIP] Adding boolean state sensor control to Chef
393662c 
- Add new RPCs to set/read BooleanState cluster
- Update nRF, ESP32 and Linux chef examples to include
- Update some docs that were stale
- Allow StatusUtils for RPC to deal with CHIP_ERROR

Issue project-chip#25225
Fixes project-chip#31725
@tcarmelveilleux tcarmelveilleux mentioned this issue Jan 29, 2024
Merged
mergify bot pushed a commit that referenced this issue Jan 29, 2024
@tcarmelveilleux @erwinpan1 @restyled-commits
Add BooleanState cluster control to pigweed RPCs (#31745)
adcf742 
* [WIP] Adding boolean state sensor control to Chef

- Add new RPCs to set/read BooleanState cluster
- Update nRF, ESP32 and Linux chef examples to include
- Update some docs that were stale
- Allow StatusUtils for RPC to deal with CHIP_ERROR

Issue #25225
Fixes #31725

* Support BooleanState in RPC console

* Restyled by clang-format

* Fix ESP32 build

* Rename EmberOrChipStatusToPwStatus to ToPwmStatus

---------

Co-authored-by: erwinpan1 <erwinpan1@gmail.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app-clusters Application cluster work spec Mismatch between spec and implementation
Projects
[Enhancements] Spec/XML Alignment
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andy31415 @bzbarsky-apple