Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Launcher cluster implementation assumes the "Application" field is always present in commands. #24595

Open
bzbarsky-apple opened this issue Jan 23, 2023 · 1 comment
Assignees
Labels
app-clusters Application cluster work spec Mismatch between spec and implementation tv TV-related features

Comments

@bzbarsky-apple
Copy link
Contributor

The "LaunchApp", "StopApp", "HideApp" commands only have an Application field if the AP feature is supported. But the current implementation will fail out if those fields are not provided no matter what features might or might not be enabled.

This requires fixes to emberAfApplicationLauncherClusterLaunchAppCallback and the like, as well as the delegate methods they call (which assume you have an ApplicationStruct for them), etc.

@bzbarsky-apple bzbarsky-apple added spec Mismatch between spec and implementation app-clusters Application cluster work tv TV-related features labels Jan 23, 2023
@chrisdecenzo chrisdecenzo self-assigned this Jan 23, 2023
@stale
Copy link

stale bot commented Aug 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Aug 7, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Aug 7, 2023
@woody-apple woody-apple added this to the No Target Milestone milestone Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-clusters Application cluster work spec Mismatch between spec and implementation tv TV-related features
Projects
Status: Todo
Development

No branches or pull requests

3 participants