Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve expected result handling in java matter controller test #23730

Closed
yunhanw-google opened this issue Nov 22, 2022 · 0 comments · Fixed by #24311
Closed

Improve expected result handling in java matter controller test #23730

yunhanw-google opened this issue Nov 22, 2022 · 0 comments · Fixed by #24311
Assignees
@yunhanw-google
Labels
java Issues in java-matter-controller

Comments

@yunhanw-google
Copy link
Contributor 

    A string seems to make it hard to figure out if this was a success or a failure. Ideally we would have some form of class instead, where we could have `SUCCESS` or `FAILURE(optional_error_string)`. That allows us to easily check for success and not rely on copy & paste of strings containing magic words.

Could we make this change? Ok if a followup, but should be soon.

Originally posted by @andy31415 in #23714 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yunhanw-google yunhanw-google

Labels
java Issues in java-matter-controller
Projects
No open projects
Java Matter Controller Test
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve java matter controller example result check yunhanw-google/connectedhomeip
2 participants
@yunhanw-google @bzbarsky-apple