Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVE2] Groups Cluster Server Forces Feature Bit 0 to True #22329

Open
ifyall opened this issue Aug 31, 2022 · 2 comments
Open

[SVE2] Groups Cluster Server Forces Feature Bit 0 to True #22329

ifyall opened this issue Aug 31, 2022 · 2 comments
Labels
app-clusters Application cluster work group messaging

Comments

@ifyall
Copy link

ifyall commented Aug 31, 2022

Problem

Today, the Groups cluster implementation for Servers forces feature bit 0 (GN) to be 1/true. This is regardless of what the zap file configuration of the cluster indicates. The consequence of this is that a device maker who uses the provided groups-server.cpp won't actually know what their PICS should be. A device maker should be able to determine their PICS for their device using two inputs, the zap file or their own application code.

Since the Groups cluster ignores the zap file and doesn't allow the application code to make a choice about NameSupport via its Init function, then the device maker might reasonably set their PICS for G.S.F00 to 0/false. Then, when they try to test their device for certification, they will get failures in one or more Groups tests and not understand why.

Taking feature bit values from the zap file and allowing them to be overridden by Init API calls is a reasonable way to ask thousands of device makers to fill out their PICS. Asking thousands of device makers to read the implementation code for every cluster provided by the SDK in order to determine their PICS is not.

See lines 155 and 163 here: https://github.com/project-chip/connectedhomeip/blob/5aa5e8e/src/app/clusters/groups-server/groups-server.cpp#L150

I do not believe this should block 1.0 certification.

Proposed Solution

Two choices:

  1. Have the groups-server.cpp honor the zap file configuration
  2. The above plus allowing application authors to override the zap file explicitly via Init call for the Groups cluster.
@bzbarsky-apple bzbarsky-apple added app-clusters Application cluster work group messaging labels Aug 31, 2022
@stale
Copy link

stale bot commented Mar 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@ifyall
Copy link
Author

ifyall commented Mar 7, 2023

Is there an issue grooming process that should pick this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-clusters Application cluster work group messaging
Projects
None yet
Development

No branches or pull requests

4 participants