Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the WriteClient constructor actually behaves differently depending on CONFIG_BUILD_FOR_HOST_UNIT_TEST, so this test is completely broken if that's ever not defined. #21737

Open
yunhanw-google opened this issue Aug 8, 2022 · 2 comments

Comments

@yunhanw-google
Copy link
Contributor

Per Slack discussion: the WriteClient constructor actually behaves differently depending on CONFIG_BUILD_FOR_HOST_UNIT_TEST, so this test is completely broken if that's ever not defined....

We need to fix things so that's not the case, but that is not part of this PR. Needs a followup.

Originally posted by @bzbarsky-apple in #21707 (comment)

@stale
Copy link

stale bot commented Feb 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Feb 5, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Feb 6, 2023
@stale
Copy link

stale bot commented Aug 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Aug 7, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants