Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-IDM-2.2]While verifying Read Request Message to the DUT from TH to read any attribute to an unsupported node throws an invalid error instead UNSUPPORTED_NODE(0x9B) #17500

Closed
Rajashreekalmane opened this issue Apr 19, 2022 · 5 comments
Assignees

Comments

@Rajashreekalmane
Copy link

Rajashreekalmane commented Apr 19, 2022

Problem

As per Test-Plan test step 13 While verifying Read Request Message to the DUT from TH to read any attribute to an unsupported node throws an Run command failure instead UNSUPPORTED_NODE(0x9B).

  • Expected behavior:-UNSUPPORTED_NODE(0x9B)

  • Actual behavior:- Run command failure: ../../third_party/connectedhomeip/src/lib/address_resolve/AddressResolve_DefaultImpl.cpp:174: CHIP Error 0x00000032: Timeout

  • steps to reproduce:-
    While pairing provided nodeID as 1
    ./chip-tool pairing ble-wifi 1 zigbee1 matter123 20202021 3840
    To verify test step 13 of this test-case[TC-IDM-2.2] provided nodeID as 2
    ./chip-tool basic read product-name 2 0

  • system configuration
    Chip-Tool: RPI
    DUT: RPI
    Platform : IP and Wifi
    Commit-ID: 2982c0c
    Dut: All-Clusters-app

Test-Plan Reference:-
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/interactiondatamodel.adoc#tc-idm-2-2-report-data-action-from-dut-to-th

Spec Reference:-
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/data_model/Interaction-Model.adoc#ref_IM.StatusCodeTable

PFA log below:-
Unsupported NodeID.txt

@Rajashreekalmane Rajashreekalmane changed the title [TC-IDM-2.2]While verifying Read Request Message to the DUT from TH to read any attribute to an unsupported node throws an Run command failure instead UNSUPPORTED_NODE(0x9B) [TC-IDM-2.2]While verifying Read Request Message to the DUT from TH to read any attribute to an unsupported node throws an invalid error instead UNSUPPORTED_NODE(0x9B) Apr 19, 2022
@vivien-apple
Copy link
Contributor

This is basically #16705

@yunhanw-google
Copy link
Contributor

Per jerry, #16705 (comment), so we need to close it.

@yunhanw-google
Copy link
Contributor

@bzbarsky-apple since we are not supporting unsupported_node, I think timeout error is valid here?

@bzbarsky-apple
Copy link
Contributor

The test plan described above can't be tested with the 1.0 SDK at all.

The test steps above, in particular, would not lead to UNSUPPORTED_NODE even if that were implemented. They would just lead to a discovery error, or no error at all, just talking to the wrong node.

A test step that could lead to UNSUPPORTED_NODE would involve sending an actual Node id in a path that does not match the right Node id. And as I said, the current SDK cannot do it. And yes, the only place where this would be useful is proxies, and proxies are out of scope for 1.0, so it's not getting implemented for 1.0.

So that's the summary:

  1. The test plan cannot be tested with the SDK.
  2. The steps above do not test what the test plan wants to test.

@Rajashreekalmane
Copy link
Author

@bzbarsky-apple Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants