Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This DataVersionFilter should really inherit from ConcreteClusterPath #17227

Open
yunhanw-google opened this issue Apr 9, 2022 · 3 comments
Open

This DataVersionFilter should really inherit from ConcreteClusterPath #17227

yunhanw-google opened this issue Apr 9, 2022 · 3 comments
Assignees
@yunhanw-google
Labels
Interaction Model Work

Comments

@yunhanw-google
Copy link
Contributor

This DataVersionFilter should really inherit from ConcreteClusterPath. But ok for now, I guess.

This should be called something like IncludesAttributesInCluster.

Originally posted by @bzbarsky-apple in #16602 (comment)
@yunhanw-google yunhanw-google self-assigned this Apr 9, 2022
@yunhanw-google yunhanw-google mentioned this issue Apr 9, 2022
Merged
@stale
Copy link

stale bot commented Oct 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 8, 2022
@bzbarsky-apple bzbarsky-apple added Interaction Model Work and removed stale Stale issue or PR labels Oct 10, 2022
@stale
Copy link

stale bot commented Apr 11, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Apr 11, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Apr 11, 2023
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 15, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yunhanw-google yunhanw-google

Labels
Interaction Model Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yunhanw-google @bzbarsky-apple