Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: project-chip/connectedhomeip
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1c47d0fe233affd9e939026e3fb2f6b689b7313e
Choose a base ref
...
head repository: project-chip/connectedhomeip
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7eb25db8cbd9b7c6c10feecccb2e711dea834e1b
Choose a head ref
  • 15 commits
  • 170 files changed
  • 14 contributors

Commits on Jul 16, 2022

  1. Revert "Set detect_leaks=1 in various places where we do ASAN builds … 

    …in CI. (#20246)" (#20827)

This reverts commit 293ce20.
    @woody-apple
    woody-apple authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    cd4ab7c View commit details
    Browse the repository at this point in the history

  2. Log error on bad packets instead of silent return (#20126) 

    * Log error on bad packets instead of silent return

* update message text

* fix typo
    @andy31415
    andy31415 authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    4b1f365 View commit details
    Browse the repository at this point in the history

  3. Implement updated spec rules related to CATs (#20776) 

    * Implement updated spec rules related to CATs

- CAT identifiers could previously collide, which made their use ambiguous
  for access conntrol
- CAT tag class did not enforce strongly that all CATs are at the front and
  this is not required for correctness
- CAT identifiers could be value 0 before

Based on CHIP-Specifications/connectedhomeip-spec#5437
we need to fix this.

Fixes #20746

This PR:

- Checks CATs are valid when adding/updating NOCs
- Adds an `AreValid()` method to CATValues to ensure
  correctness

Testing done:
- Added unit tests for all new methods
- Cert tests still pass

* Apply review comment from @mstandstedt

* Fix Darwin tests.

* Restyle

* Update access control to use CASEAuthTag methods

* Rename variables to clarify logic

* Fix another use of direct masks

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
    @tcarmelveilleux @bzbarsky-apple
    tcarmelveilleux and bzbarsky-apple authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    ce92c97 View commit details
    Browse the repository at this point in the history

  4. [chip-cert] Updated support for HEX encoding to certificate tool. (#2… 

    …0561)

- Added HEX format support for the DER encoded data.
  - Added HEX foramt support for the Certification Declaration data.
  - Added support for only Public Key (without Private Key) including public key in HEX format.
  - Code refactored.
    @emargolis
    emargolis authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    aa7c0ba View commit details
    Browse the repository at this point in the history

  5. Update ZAP metadata in ZCL files. (#20640) 

    * Update ZAP metadata in ZCL files.

With matter nearing release, the category of the ZCL data needs
to be differentiated, so zigbee pro stacks use "zigbee" category
and Matter stack uses "matter" category.

None of this affects generation, but it affects the user flow in
the UI, where user might be upgrading old Matter or old ZigbeePro
file, and this meta info helps determine which metafiles are
the ones that should be used for the upgrades.

It's important that this change makes it into the Matter SDK before
it becomes any kind of GA release to the customers, otherwise
when zap is upgrading from one to another version of Matter, it
will have to do guessing or ask the user for what to do.

* When doing ZCL file comparison, ignore differences in description.
    @tecimovic
    tecimovic authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    73a94a2 View commit details
    Browse the repository at this point in the history

  6. Enabled building apps for linux armhf with chef. (#20674)

    @rwells1703
    rwells1703 authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    b5ec814 View commit details
    Browse the repository at this point in the history

  7. EFR32: Device Attestation Credentials Provider implementation. (#20686) 

    * EFR32: Device Attestation Credentials Provider implementation.

* EFR32 DAC Provider: Review comments applied.
    @rcasallas-silabs
    rcasallas-silabs authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    0e9122e View commit details
    Browse the repository at this point in the history

  8. [Tizen] Do not create flashbundle for non-TPK apps (#20730) 

    * [Tizen] Do not create flashbundle for non-TPK apps

* For example apps create Tizen security profile on the fly
    @arkq
    arkq authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    8a32b6c View commit details
    Browse the repository at this point in the history

  9. [Ameba] Implement erase partition in Abort function (#20741) 

    * [OTA] Implement erase partition in Abort function

* [OTA] Increase delay before reboot to 10 seconds
- This allows time to send out events, for eg state transition from downloading to applying

* Restyled by clang-format

Co-authored-by: Restyled.io <commits@restyled.io>
    @pankore @restyled-commits
    pankore and restyled-commits authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    207d89b View commit details
    Browse the repository at this point in the history

  10. [Ameba] Fixes to pass the PersistentStorage storage_audit (#20792) 

    * [PersistentStorage] Fixes to pass the PersistentStorage storage_audit
- Map DCT errors to CHIPError in KeyValueStoreManagerImpl
- Add matter_enable_persistentstorage_audit option in CMake files

* Restyled by clang-format

Co-authored-by: Restyled.io <commits@restyled.io>
    @pankore @restyled-commits
    pankore and restyled-commits authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    cd42353 View commit details
    Browse the repository at this point in the history

  11. Updated Manual scripts verification steps and PICS (#20759) 

    * Added Manual scripts

* Added Auto generated files

* Restyled by whitespace

* Restyled by clang-format

* Added update PICS file

* 1.Removing deprecated PICS definition

* Increasing move command delay.

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: kvikrambhat <vikrambhat@outlook.com>
    @kowsisoundhar12 @restyled-commits @kvikrambhat
    3 people authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    fd91bea View commit details
    Browse the repository at this point in the history

  12. [Ameba] Set matter_enable_persistentstorage_audit as disabled by defa… 

    …ult (#20777)
    @pankore
    pankore authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    e19242e View commit details
    Browse the repository at this point in the history

  13. Reset error state when shutting down chip-tool commands. (#20818) 

    Some commands store an error status.  If they fail, the next invocation of the
same command in interactive mode will also claim to have failed, even if it
succeeded, because the error status carries over.

The fix is to reset the error status on Shutdown of the command.
    @bzbarsky-apple
    bzbarsky-apple authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    bd077fe View commit details
    Browse the repository at this point in the history

  14. add enum check

    @yunhanw-google
    yunhanw-google committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    4871b19 View commit details
    Browse the repository at this point in the history

  15. run codegen

    @yunhanw-google
    yunhanw-google committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    7eb25db View commit details
    Browse the repository at this point in the history
Loading