From d99f00942e63512fced6f67b253aaec1400a3dc3 Mon Sep 17 00:00:00 2001 From: Yufeng Wang Date: Wed, 18 May 2022 13:18:20 -0700 Subject: [PATCH] Remove unused functions in DiagnosticDataProviderImpl --- src/include/platform/DiagnosticDataProvider.h | 6 ------ src/platform/Linux/DiagnosticDataProviderImpl.cpp | 8 -------- src/platform/Linux/DiagnosticDataProviderImpl.h | 1 - 3 files changed, 15 deletions(-) diff --git a/src/include/platform/DiagnosticDataProvider.h b/src/include/platform/DiagnosticDataProvider.h index fa4165f2bc0dc1..8401c292d2932f 100644 --- a/src/include/platform/DiagnosticDataProvider.h +++ b/src/include/platform/DiagnosticDataProvider.h @@ -179,7 +179,6 @@ class DiagnosticDataProvider virtual CHIP_ERROR GetCurrentHeapFree(uint64_t & currentHeapFree); virtual CHIP_ERROR GetCurrentHeapUsed(uint64_t & currentHeapUsed); virtual CHIP_ERROR GetCurrentHeapHighWatermark(uint64_t & currentHeapHighWatermark); - virtual CHIP_ERROR SetCurrentHeapHighWatermark(uint64_t heapHighWatermark); virtual CHIP_ERROR ResetWatermarks(); /* @@ -268,11 +267,6 @@ inline CHIP_ERROR DiagnosticDataProvider::GetCurrentHeapHighWatermark(uint64_t & return CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE; } -inline CHIP_ERROR DiagnosticDataProvider::SetCurrentHeapHighWatermark(uint64_t heapHighWatermark) -{ - return CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE; -} - inline CHIP_ERROR DiagnosticDataProvider::ResetWatermarks() { return CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE; diff --git a/src/platform/Linux/DiagnosticDataProviderImpl.cpp b/src/platform/Linux/DiagnosticDataProviderImpl.cpp index c97aeca2cb4833..2d5836773e4ef3 100644 --- a/src/platform/Linux/DiagnosticDataProviderImpl.cpp +++ b/src/platform/Linux/DiagnosticDataProviderImpl.cpp @@ -266,14 +266,6 @@ CHIP_ERROR DiagnosticDataProviderImpl::GetCurrentHeapHighWatermark(uint64_t & cu #endif } -CHIP_ERROR DiagnosticDataProviderImpl::SetCurrentHeapHighWatermark(uint64_t heapHighWatermark) -{ - // On Linux, the write operation is non-op since we always rely on the mallinfo system - // function to get the current heap memory. - - return CHIP_NO_ERROR; -} - CHIP_ERROR DiagnosticDataProviderImpl::ResetWatermarks() { // If implemented, the server SHALL set the value of the CurrentHeapHighWatermark attribute to the diff --git a/src/platform/Linux/DiagnosticDataProviderImpl.h b/src/platform/Linux/DiagnosticDataProviderImpl.h index d3797d63a9a175..02b43cdf448f82 100644 --- a/src/platform/Linux/DiagnosticDataProviderImpl.h +++ b/src/platform/Linux/DiagnosticDataProviderImpl.h @@ -43,7 +43,6 @@ class DiagnosticDataProviderImpl : public DiagnosticDataProvider CHIP_ERROR GetCurrentHeapUsed(uint64_t & currentHeapUsed) override; CHIP_ERROR GetCurrentHeapHighWatermark(uint64_t & currentHeapHighWatermark) override; CHIP_ERROR GetThreadMetrics(ThreadMetrics ** threadMetricsOut) override; - CHIP_ERROR SetCurrentHeapHighWatermark(uint64_t heapHighWatermark) override; CHIP_ERROR ResetWatermarks() override; void ReleaseThreadMetrics(ThreadMetrics * threadMetrics) override;