From d43ef8558400ff7412ecf96e13ca2ba0cd24f80e Mon Sep 17 00:00:00 2001 From: Vivien Nicolas Date: Thu, 27 Oct 2022 09:01:28 +0200 Subject: [PATCH] Update default MRP config to match the spec (#23344) --- src/messaging/ReliableMessageProtocolConfig.cpp | 2 +- src/messaging/ReliableMessageProtocolConfig.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/messaging/ReliableMessageProtocolConfig.cpp b/src/messaging/ReliableMessageProtocolConfig.cpp index 00abf5376dd049..a0ff8ab64ceec1 100644 --- a/src/messaging/ReliableMessageProtocolConfig.cpp +++ b/src/messaging/ReliableMessageProtocolConfig.cpp @@ -51,7 +51,7 @@ void ClearLocalMRPConfigOverride() ReliableMessageProtocolConfig GetDefaultMRPConfig() { // Default MRP intervals are defined in spec <2.11.3. Parameters and Constants> - static constexpr const System::Clock::Milliseconds32 idleRetransTimeout = 4000_ms32; + static constexpr const System::Clock::Milliseconds32 idleRetransTimeout = 300_ms32; static constexpr const System::Clock::Milliseconds32 activeRetransTimeout = 300_ms32; return ReliableMessageProtocolConfig(idleRetransTimeout, activeRetransTimeout); } diff --git a/src/messaging/ReliableMessageProtocolConfig.h b/src/messaging/ReliableMessageProtocolConfig.h index eaefaa3ecfe8e1..b705d05beec621 100644 --- a/src/messaging/ReliableMessageProtocolConfig.h +++ b/src/messaging/ReliableMessageProtocolConfig.h @@ -39,7 +39,7 @@ namespace chip { * subsequent failures in milliseconds. * * This is the default value, that might be adjusted by end device depending on its - * needs (e.g. sleeping period) using Service Discovery TXT record CRA key. + * needs (e.g. sleeping period) using Service Discovery TXT record SAI key. * */ #ifndef CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL @@ -54,10 +54,10 @@ namespace chip { * failure in milliseconds. * * This is the default value, that might be adjusted by end device depending on its - * needs (e.g. sleeping period) using Service Discovery TXT record CRI key. + * needs (e.g. sleeping period) using Service Discovery TXT record SII key. */ #ifndef CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL -#define CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL (5000_ms32) +#define CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL (300_ms32) #endif // CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL /**