From d137dbf9cb8a7c022b3b14c7302f1b3202472b4b Mon Sep 17 00:00:00 2001 From: JasonLiuZhuoCheng Date: Thu, 4 Nov 2021 15:31:56 -0400 Subject: [PATCH] resolve comments --- .../.idea/deploymentTargetDropDown.xml | 17 ----------------- .../ClusterDetailFragment.kt | 18 ++++++++++++++++-- 2 files changed, 16 insertions(+), 19 deletions(-) delete mode 100644 src/android/CHIPTool/.idea/deploymentTargetDropDown.xml diff --git a/src/android/CHIPTool/.idea/deploymentTargetDropDown.xml b/src/android/CHIPTool/.idea/deploymentTargetDropDown.xml deleted file mode 100644 index 654c38d45ad607..00000000000000 --- a/src/android/CHIPTool/.idea/deploymentTargetDropDown.xml +++ /dev/null @@ -1,17 +0,0 @@ - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/src/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt b/src/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt index 79490146baa9aa..d90b8f4d5a88ad 100644 --- a/src/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt +++ b/src/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt @@ -84,8 +84,8 @@ class ClusterDetailFragment : Fragment() { >>>>>>> d3d83a0bc (select different cluster, command will remove previous displayed parameter) ======= clusterMap = ClusterInfoMapping().clusterMap - devicePtr = checkNotNull(requireArguments().getLong(DEVICE_PTR)) - endpointId = checkNotNull(requireArguments().getInt(ENDPOINT_ID)) + devicePtr = checkNotNull(requireArguments().getLong(DEVICE_PTR_KEY)) + endpointId = checkNotNull(requireArguments().getInt(ENDPOINT_ID_KEY)) return inflater.inflate(R.layout.cluster_detail_fragment, container, false).apply { deviceController.setCompletionListener(GenericChipDeviceListener()) commandAutoCompleteTv.visibility = View.GONE @@ -305,6 +305,7 @@ class ClusterDetailFragment : Fragment() { <<<<<<< HEAD private fun constructHint(clusterMap: Map): Array { return clusterMap.keys.toTypedArray() +<<<<<<< HEAD ======= private fun constructHint(clusterMap: HashMap): Array { ======= @@ -316,6 +317,8 @@ class ClusterDetailFragment : Fragment() { } return clusterName.toTypedArray() >>>>>>> d3d83a0bc (select different cluster, command will remove previous displayed parameter) +======= +>>>>>>> d419b4060 (resolve comments) } override fun onStop() { @@ -326,6 +329,7 @@ class ClusterDetailFragment : Fragment() { companion object { private const val TAG = "ClusterDetailFragment" <<<<<<< HEAD +<<<<<<< HEAD <<<<<<< HEAD private const val ENDPOINT_ID_KEY = "endpoint_id" private const val DEVICE_PTR_KEY = "device_ptr" @@ -348,15 +352,25 @@ class ClusterDetailFragment : Fragment() { ======= private const val ENDPOINT_ID = "endpoint_id" private const val DEVICE_PTR = "device_ptr" +======= + private const val ENDPOINT_ID_KEY = "endpoint_id" + private const val DEVICE_PTR_KEY = "device_ptr" + +>>>>>>> d419b4060 (resolve comments) fun newInstance( deviceId: Long, endpointId: Int ): ClusterDetailFragment { return ClusterDetailFragment().apply { arguments = Bundle(2).apply { +<<<<<<< HEAD putLong(DEVICE_PTR, deviceId) putInt(ENDPOINT_ID, endpointId) >>>>>>> cd1c99028 (resolve comments) +======= + putLong(DEVICE_PTR_KEY, deviceId) + putInt(ENDPOINT_ID_KEY, endpointId) +>>>>>>> d419b4060 (resolve comments) } } }