diff --git a/.clang-tidy b/.clang-tidy index 2fa534bc5d2e77..580234c0fad0a3 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,36 +1,42 @@ --- Checks: > - readability-else-after-return, - modernize-use-nullptr, bugprone-*, - -bugprone-not-null-terminated-result, - -bugprone-unused-return-value, + modernize-use-bool-literals, + modernize-use-nullptr, + performance-for-range-copy, + readability-const-return-type, + readability-else-after-return, + readability-redundant-control-flow, + readability-redundant-string-cstr, + readability-redundant-string-init, -bugprone-branch-clone, + -bugprone-copy-constructor-init, -bugprone-easily-swappable-parameters, - -bugprone-reserved-identifier, - -bugprone-macro-parentheses, -bugprone-forward-declaration-namespace, -bugprone-forwarding-reference-overload, - -bugprone-undelegated-constructor, -bugprone-implicit-widening-of-multiplication-result, - -bugprone-narrowing-conversions, + -bugprone-macro-parentheses, -bugprone-misplaced-widening-cast, - -bugprone-suspicious-include, + -bugprone-narrowing-conversions, + -bugprone-not-null-terminated-result, + -bugprone-reserved-identifier, -bugprone-signed-char-misuse, - -bugprone-copy-constructor-init, + -bugprone-suspicious-include, + -bugprone-undelegated-constructor, + -bugprone-unused-return-value, -clang-analyzer-core.CallAndMessage, + -clang-analyzer-core.NonNullParamChecker, -clang-analyzer-core.NullDereference, - -clang-analyzer-optin.cplusplus.UninitializedObject, - -clang-analyzer-optin.performance, - -clang-analyzer-optin.osx.cocoa.localizability.EmptyLocalizationContextChecker, - -clang-analyzer-deadcode.DeadStores, -clang-analyzer-cplusplus.Move, - -clang-analyzer-optin.cplusplus.VirtualCall, - -clang-analyzer-security.insecureAPI.strcpy, + -clang-analyzer-deadcode.DeadStores, -clang-analyzer-nullability.NullablePassedToNonnull, + -clang-analyzer-optin.cplusplus.UninitializedObject, + -clang-analyzer-optin.cplusplus.VirtualCall, + -clang-analyzer-optin.osx.cocoa.localizability.EmptyLocalizationContextChecker, + -clang-analyzer-optin.performance, -clang-analyzer-optin.performance.Padding, -clang-analyzer-security.insecureAPI.rand, - -clang-analyzer-core.NonNullParamChecker, + -clang-analyzer-security.insecureAPI.strcpy, -clang-analyzer-unix.Malloc, -clang-diagnostic-implicit-int-conversion WarningsAsErrors: '*' diff --git a/.github/dependabot.yml b/.github/dependabot.yml index b76094b34ad4b2..cf59391ca0ef32 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -7,4 +7,4 @@ updates: allow: - dependency-name: "third_party/pigweed/repo" - dependency-name: "third_party/mbedtls/repo" - - dependancy-name: "third_party/openthread/repo" + - dependency-name: "third_party/openthread/repo" diff --git a/config/nrfconnect/chip-module/Kconfig b/config/nrfconnect/chip-module/Kconfig index b377c65c2e222f..e4a0a9f3a1abab 100644 --- a/config/nrfconnect/chip-module/Kconfig +++ b/config/nrfconnect/chip-module/Kconfig @@ -284,5 +284,9 @@ config CHIP_CERTIFiCATION_DECLARATION_OTA_IMAGE_ID endif +# See config/zephyr/Kconfig for full definition +config CHIP_FACTORY_RESET_ERASE_NVS + bool + default y if CHIP_FACTORY_DATA || CHIP_FACTORY_DATA_CUSTOM_BACKEND endif diff --git a/config/zephyr/Kconfig b/config/zephyr/Kconfig index efa0f7abc2c476..9928bb35b49258 100644 --- a/config/zephyr/Kconfig +++ b/config/zephyr/Kconfig @@ -202,6 +202,17 @@ config CHIP_CRYPTO_PSA Use the backend for the Matter crypto layer that is based on PSA crypto API instead of the default, based on legacy mbedTLS APIs. +config CHIP_FACTORY_RESET_ERASE_NVS + bool "Erase NVS flash pages on factory reset" + depends on SETTINGS_NVS + help + When factory reset is requested, erase flash pages occupied by non-volatile storage + instead of removing Matter-related settings only. This provides a more robust + factory reset mechanism and allows to regain the original storage performance if any + firmware issue has brought it to an unexpected state. For this reason, it is + advisable to set this option if all configuration, including device-specific + entries, is supposed to be cleared on a factory reset. + config CHIP_MALLOC_SYS_HEAP bool "Memory allocator based on Zephyr sys_heap" imply SYS_HEAP_RUNTIME_STATS diff --git a/docs/guides/nrfconnect_examples_configuration.md b/docs/guides/nrfconnect_examples_configuration.md index 119852b3929a89..0254d8bb390644 100644 --- a/docs/guides/nrfconnect_examples_configuration.md +++ b/docs/guides/nrfconnect_examples_configuration.md @@ -193,6 +193,15 @@ instead of using a QR code, which is the default configuration. To enable NFC for commissioning and share the onboarding payload in an NFC tag, set the `CONFIG_CHIP_NFC_COMMISSIONING` option. +**Factory reset behavior** + +By default, the factory reset procedure implemented in the Matter stack removes +Matter-related settings only. If your application does not depend on any +device-lifelong data stored in the non-volatile storage, set the +`CONFIG_CHIP_FACTORY_RESET_ERASE_NVS` option to fully erase the NVS partition at +the factory reset. This approach is more robust and regains the original NVS +performance in case it has been polluted with unwanted entries. + **Logging** You can enable logging for both the stack and Zephyr’s diff --git a/examples/all-clusters-app/all-clusters-common/all-clusters-app.zap b/examples/all-clusters-app/all-clusters-common/all-clusters-app.zap index 840f51d0ad993a..99d72eeea360c9 100644 --- a/examples/all-clusters-app/all-clusters-common/all-clusters-app.zap +++ b/examples/all-clusters-app/all-clusters-common/all-clusters-app.zap @@ -1530,7 +1530,7 @@ "name": "OTA Software Update Provider", "code": 41, "mfgCode": null, - "define": "OTA_PROVIDER_CLUSTER", + "define": "OTA_SOFTWARE_UPDATE_PROVIDER_CLUSTER", "side": "client", "enabled": 1, "commands": [ @@ -1582,7 +1582,7 @@ "name": "OTA Software Update Provider", "code": 41, "mfgCode": null, - "define": "OTA_PROVIDER_CLUSTER", + "define": "OTA_SOFTWARE_UPDATE_PROVIDER_CLUSTER", "side": "server", "enabled": 0, "commands": [ @@ -1658,7 +1658,7 @@ "name": "OTA Software Update Requestor", "code": 42, "mfgCode": null, - "define": "OTA_REQUESTOR_CLUSTER", + "define": "OTA_SOFTWARE_UPDATE_REQUESTOR_CLUSTER", "side": "client", "enabled": 0, "commands": [ @@ -1694,7 +1694,7 @@ "name": "OTA Software Update Requestor", "code": 42, "mfgCode": null, - "define": "OTA_REQUESTOR_CLUSTER", + "define": "OTA_SOFTWARE_UPDATE_REQUESTOR_CLUSTER", "side": "server", "enabled": 1, "attributes": [ @@ -7710,7 +7710,7 @@ "name": "Temperature Measurement", "code": 1026, "mfgCode": null, - "define": "TEMP_MEASUREMENT_CLUSTER", + "define": "TEMPERATURE_MEASUREMENT_CLUSTER", "side": "client", "enabled": 0, "attributes": [ @@ -7736,7 +7736,7 @@ "name": "Temperature Measurement", "code": 1026, "mfgCode": null, - "define": "TEMP_MEASUREMENT_CLUSTER", + "define": "TEMPERATURE_MEASUREMENT_CLUSTER", "side": "server", "enabled": 0, "attributes": [ @@ -9396,7 +9396,7 @@ "name": "On/off Switch Configuration", "code": 7, "mfgCode": null, - "define": "ON_OFF_SWITCH_CONFIG_CLUSTER", + "define": "ON_OFF_SWITCH_CONFIGURATION_CLUSTER", "side": "client", "enabled": 0, "attributes": [ @@ -9422,7 +9422,7 @@ "name": "On/off Switch Configuration", "code": 7, "mfgCode": null, - "define": "ON_OFF_SWITCH_CONFIG_CLUSTER", + "define": "ON_OFF_SWITCH_CONFIGURATION_CLUSTER", "side": "server", "enabled": 1, "attributes": [ @@ -10770,7 +10770,7 @@ "name": "OTA Software Update Provider", "code": 41, "mfgCode": null, - "define": "OTA_PROVIDER_CLUSTER", + "define": "OTA_SOFTWARE_UPDATE_PROVIDER_CLUSTER", "side": "client", "enabled": 0, "commands": [ @@ -10814,7 +10814,7 @@ "name": "OTA Software Update Provider", "code": 41, "mfgCode": null, - "define": "OTA_PROVIDER_CLUSTER", + "define": "OTA_SOFTWARE_UPDATE_PROVIDER_CLUSTER", "side": "server", "enabled": 0, "commands": [ @@ -10850,7 +10850,7 @@ "name": "OTA Software Update Requestor", "code": 42, "mfgCode": null, - "define": "OTA_REQUESTOR_CLUSTER", + "define": "OTA_SOFTWARE_UPDATE_REQUESTOR_CLUSTER", "side": "client", "enabled": 0, "attributes": [ @@ -10876,7 +10876,7 @@ "name": "OTA Software Update Requestor", "code": 42, "mfgCode": null, - "define": "OTA_REQUESTOR_CLUSTER", + "define": "OTA_SOFTWARE_UPDATE_REQUESTOR_CLUSTER", "side": "server", "enabled": 0, "attributes": [ @@ -14102,7 +14102,7 @@ "name": "Pump Configuration and Control", "code": 512, "mfgCode": null, - "define": "PUMP_CONFIG_CONTROL_CLUSTER", + "define": "PUMP_CONFIGURATION_AND_CONTROL_CLUSTER", "side": "client", "enabled": 0, "attributes": [ @@ -14128,7 +14128,7 @@ "name": "Pump Configuration and Control", "code": 512, "mfgCode": null, - "define": "PUMP_CONFIG_CONTROL_CLUSTER", + "define": "PUMP_CONFIGURATION_AND_CONTROL_CLUSTER", "side": "server", "enabled": 1, "attributes": [ @@ -15308,7 +15308,7 @@ "name": "Thermostat User Interface Configuration", "code": 516, "mfgCode": null, - "define": "THERMOSTAT_UI_CONFIG_CLUSTER", + "define": "THERMOSTAT_USER_INTERFACE_CONFIGURATION_CLUSTER", "side": "client", "enabled": 0, "attributes": [ @@ -15334,7 +15334,7 @@ "name": "Thermostat User Interface Configuration", "code": 516, "mfgCode": null, - "define": "THERMOSTAT_UI_CONFIG_CLUSTER", + "define": "THERMOSTAT_USER_INTERFACE_CONFIGURATION_CLUSTER", "side": "server", "enabled": 1, "attributes": [ @@ -16626,7 +16626,7 @@ "name": "Temperature Measurement", "code": 1026, "mfgCode": null, - "define": "TEMP_MEASUREMENT_CLUSTER", + "define": "TEMPERATURE_MEASUREMENT_CLUSTER", "side": "client", "enabled": 0, "attributes": [ @@ -16652,7 +16652,7 @@ "name": "Temperature Measurement", "code": 1026, "mfgCode": null, - "define": "TEMP_MEASUREMENT_CLUSTER", + "define": "TEMPERATURE_MEASUREMENT_CLUSTER", "side": "server", "enabled": 1, "attributes": [ @@ -18314,7 +18314,7 @@ "name": "Content Launcher", "code": 1290, "mfgCode": null, - "define": "CONTENT_LAUNCH_CLUSTER", + "define": "CONTENT_LAUNCHER_CLUSTER", "side": "client", "enabled": 0, "commands": [ @@ -18358,7 +18358,7 @@ "name": "Content Launcher", "code": 1290, "mfgCode": null, - "define": "CONTENT_LAUNCH_CLUSTER", + "define": "CONTENT_LAUNCHER_CLUSTER", "side": "server", "enabled": 1, "attributes": [ @@ -24128,7 +24128,7 @@ "name": "Temperature Measurement", "code": 1026, "mfgCode": null, - "define": "TEMP_MEASUREMENT_CLUSTER", + "define": "TEMPERATURE_MEASUREMENT_CLUSTER", "side": "client", "enabled": 0, "attributes": [ @@ -24154,7 +24154,7 @@ "name": "Temperature Measurement", "code": 1026, "mfgCode": null, - "define": "TEMP_MEASUREMENT_CLUSTER", + "define": "TEMPERATURE_MEASUREMENT_CLUSTER", "side": "server", "enabled": 0, "attributes": [ diff --git a/examples/all-clusters-app/all-clusters-common/include/static-supported-modes-manager.h b/examples/all-clusters-app/all-clusters-common/include/static-supported-modes-manager.h index 2d4f674a65920d..8c9515738fa7da 100644 --- a/examples/all-clusters-app/all-clusters-common/include/static-supported-modes-manager.h +++ b/examples/all-clusters-app/all-clusters-common/include/static-supported-modes-manager.h @@ -54,7 +54,7 @@ class StaticSupportedModesManager : public chip::app::Clusters::ModeSelect::Supp public: static const StaticSupportedModesManager instance; - const SupportedModesManager::ModeOptionsProvider getModeOptionsProvider(EndpointId endpointId) const override; + SupportedModesManager::ModeOptionsProvider getModeOptionsProvider(EndpointId endpointId) const override; EmberAfStatus getModeOptionByMode(EndpointId endpointId, uint8_t mode, const ModeOptionStructType ** dataPtr) const override; diff --git a/examples/all-clusters-app/all-clusters-common/src/static-supported-modes-manager.cpp b/examples/all-clusters-app/all-clusters-common/src/static-supported-modes-manager.cpp index 8308ab8538de17..c9f118464c27ae 100644 --- a/examples/all-clusters-app/all-clusters-common/src/static-supported-modes-manager.cpp +++ b/examples/all-clusters-app/all-clusters-common/src/static-supported-modes-manager.cpp @@ -39,7 +39,7 @@ const StaticSupportedModesManager::EndpointSpanPair const StaticSupportedModesManager StaticSupportedModesManager::instance = StaticSupportedModesManager(); -const SupportedModesManager::ModeOptionsProvider StaticSupportedModesManager::getModeOptionsProvider(EndpointId endpointId) const +SupportedModesManager::ModeOptionsProvider StaticSupportedModesManager::getModeOptionsProvider(EndpointId endpointId) const { for (auto & endpointSpanPair : supportedOptionsByEndpoints) { diff --git a/examples/all-clusters-app/cc13x2x7_26x2x7/main/AppTask.cpp b/examples/all-clusters-app/cc13x2x7_26x2x7/main/AppTask.cpp index 14645f267a43db..871a5f71d6acc0 100644 --- a/examples/all-clusters-app/cc13x2x7_26x2x7/main/AppTask.cpp +++ b/examples/all-clusters-app/cc13x2x7_26x2x7/main/AppTask.cpp @@ -148,7 +148,7 @@ int AppTask::StartAppTask() if (sAppEventQueue == NULL) { PLAT_LOG("Failed to allocate app event queue"); - while (1) + while (true) ; } @@ -157,7 +157,7 @@ int AppTask::StartAppTask() pdPASS) { PLAT_LOG("Failed to create app task"); - while (1) + while (true) ; } return ret; @@ -205,7 +205,7 @@ int AppTask::Init() if (ret != CHIP_NO_ERROR) { PLAT_LOG("PlatformMgr().InitChipStack() failed"); - while (1) + while (true) ; } @@ -213,7 +213,7 @@ int AppTask::Init() if (ret != CHIP_NO_ERROR) { PLAT_LOG("ThreadStackMgr().InitThreadStack() failed"); - while (1) + while (true) ; } @@ -221,7 +221,7 @@ int AppTask::Init() if (ret != CHIP_NO_ERROR) { PLAT_LOG("ConnectivityMgr().SetThreadDeviceType() failed"); - while (1) + while (true) ; } @@ -229,7 +229,7 @@ int AppTask::Init() if (ret != CHIP_NO_ERROR) { PLAT_LOG("PlatformMgr().StartEventLoopTask() failed"); - while (1) + while (true) ; } @@ -237,7 +237,7 @@ int AppTask::Init() if (ret != CHIP_NO_ERROR) { PLAT_LOG("ThreadStackMgr().StartThreadTask() failed"); - while (1) + while (true) ; } @@ -279,7 +279,7 @@ void AppTask::AppTaskMain(void * pvParameter) sAppTask.Init(); - while (1) + while (true) { /* Task pend until we have stuff to do */ if (xQueueReceive(sAppEventQueue, &event, portMAX_DELAY) == pdTRUE) diff --git a/examples/all-clusters-app/cc13x2x7_26x2x7/main/main.cpp b/examples/all-clusters-app/cc13x2x7_26x2x7/main/main.cpp index cb0641fbc85ee0..8311c8990aa5c6 100644 --- a/examples/all-clusters-app/cc13x2x7_26x2x7/main/main.cpp +++ b/examples/all-clusters-app/cc13x2x7_26x2x7/main/main.cpp @@ -52,7 +52,7 @@ uint32_t heapSize = TOTAL_ICALL_HEAP_SIZE; // ================================================================================ extern "C" void vApplicationStackOverflowHook(void) { - while (1) + while (true) { ; } @@ -85,13 +85,13 @@ int main(void) { // can't log until the kernel is started // PLAT_LOG("GetAppTask().StartAppTask() failed"); - while (1) + while (true) ; } vTaskStartScheduler(); // Should never get here. - while (1) + while (true) ; } diff --git a/examples/all-clusters-app/infineon/psoc6/src/main.cpp b/examples/all-clusters-app/infineon/psoc6/src/main.cpp index 84b1961f9a881f..2dc8d6353cc62c 100644 --- a/examples/all-clusters-app/infineon/psoc6/src/main.cpp +++ b/examples/all-clusters-app/infineon/psoc6/src/main.cpp @@ -59,7 +59,7 @@ void appError(int err) { P6_LOG("!!!!!!!!!!!! App Critical Error: %d !!!!!!!!!!!", err); portDISABLE_INTERRUPTS(); - while (1) + while (true) ; } diff --git a/examples/all-clusters-app/nxp/mw320/main.cpp b/examples/all-clusters-app/nxp/mw320/main.cpp index df0c1dfe6f4e73..b48daf70826f4e 100644 --- a/examples/all-clusters-app/nxp/mw320/main.cpp +++ b/examples/all-clusters-app/nxp/mw320/main.cpp @@ -1027,7 +1027,7 @@ void task_main(void * param) } } - while (1) + while (true) { /* wait for interface up */ os_thread_sleep(os_msec_to_ticks(5000)); @@ -1131,7 +1131,7 @@ static void rst_args_lt(System::Layer * aSystemLayer, void * aAppState) void task_test_main(void * param) { - while (1) + while (true) { /* wait for interface up */ os_thread_sleep(os_msec_to_ticks(500)); @@ -1272,7 +1272,11 @@ void ShellCLIMain(void * pvParameter) strcpy(def_psk, "nxp12345"); } PRINTF("Connecting to [%s, %s] \r\n", def_ssid, def_psk); - ConnectivityMgrImpl().ProvisionWiFiNetwork(def_ssid, def_psk); + + // TODO: ConnectivityMgrImpl is the platform implementation of ConnectivityMgr layer. + // Application should use the APIs defined src/include/platform to talk to the Matter + // platfrom layer, instead of calling into the functions defined in the platform implemenation. + // ConnectivityMgrImpl().ProvisionWiFiNetwork(def_ssid, def_psk); } // Run CHIP servers diff --git a/examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.zap b/examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.zap index 6c11faf288ccdf..5897329987f088 100644 --- a/examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.zap +++ b/examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.zap @@ -1530,7 +1530,7 @@ "name": "OTA Software Update Provider", "code": 41, "mfgCode": null, - "define": "OTA_PROVIDER_CLUSTER", + "define": "OTA_SOFTWARE_UPDATE_PROVIDER_CLUSTER", "side": "client", "enabled": 1, "commands": [ @@ -1582,7 +1582,7 @@ "name": "OTA Software Update Provider", "code": 41, "mfgCode": null, - "define": "OTA_PROVIDER_CLUSTER", + "define": "OTA_SOFTWARE_UPDATE_PROVIDER_CLUSTER", "side": "server", "enabled": 0, "commands": [ @@ -1658,7 +1658,7 @@ "name": "OTA Software Update Requestor", "code": 42, "mfgCode": null, - "define": "OTA_REQUESTOR_CLUSTER", + "define": "OTA_SOFTWARE_UPDATE_REQUESTOR_CLUSTER", "side": "client", "enabled": 0, "commands": [ @@ -1694,7 +1694,7 @@ "name": "OTA Software Update Requestor", "code": 42, "mfgCode": null, - "define": "OTA_REQUESTOR_CLUSTER", + "define": "OTA_SOFTWARE_UPDATE_REQUESTOR_CLUSTER", "side": "server", "enabled": 1, "attributes": [ @@ -7710,7 +7710,7 @@ "name": "Temperature Measurement", "code": 1026, "mfgCode": null, - "define": "TEMP_MEASUREMENT_CLUSTER", + "define": "TEMPERATURE_MEASUREMENT_CLUSTER", "side": "client", "enabled": 0, "attributes": [ @@ -7736,7 +7736,7 @@ "name": "Temperature Measurement", "code": 1026, "mfgCode": null, - "define": "TEMP_MEASUREMENT_CLUSTER", + "define": "TEMPERATURE_MEASUREMENT_CLUSTER", "side": "server", "enabled": 0, "attributes": [ @@ -9246,7 +9246,7 @@ "name": "On/off Switch Configuration", "code": 7, "mfgCode": null, - "define": "ON_OFF_SWITCH_CONFIG_CLUSTER", + "define": "ON_OFF_SWITCH_CONFIGURATION_CLUSTER", "side": "client", "enabled": 0, "attributes": [ @@ -9272,7 +9272,7 @@ "name": "On/off Switch Configuration", "code": 7, "mfgCode": null, - "define": "ON_OFF_SWITCH_CONFIG_CLUSTER", + "define": "ON_OFF_SWITCH_CONFIGURATION_CLUSTER", "side": "server", "enabled": 0, "attributes": [ @@ -10620,7 +10620,7 @@ "name": "OTA Software Update Provider", "code": 41, "mfgCode": null, - "define": "OTA_PROVIDER_CLUSTER", + "define": "OTA_SOFTWARE_UPDATE_PROVIDER_CLUSTER", "side": "client", "enabled": 0, "commands": [ @@ -10664,7 +10664,7 @@ "name": "OTA Software Update Provider", "code": 41, "mfgCode": null, - "define": "OTA_PROVIDER_CLUSTER", + "define": "OTA_SOFTWARE_UPDATE_PROVIDER_CLUSTER", "side": "server", "enabled": 0, "commands": [ @@ -10700,7 +10700,7 @@ "name": "OTA Software Update Requestor", "code": 42, "mfgCode": null, - "define": "OTA_REQUESTOR_CLUSTER", + "define": "OTA_SOFTWARE_UPDATE_REQUESTOR_CLUSTER", "side": "client", "enabled": 0, "attributes": [ @@ -10726,7 +10726,7 @@ "name": "OTA Software Update Requestor", "code": 42, "mfgCode": null, - "define": "OTA_REQUESTOR_CLUSTER", + "define": "OTA_SOFTWARE_UPDATE_REQUESTOR_CLUSTER", "side": "server", "enabled": 0, "attributes": [ @@ -13872,7 +13872,7 @@ "name": "Pump Configuration and Control", "code": 512, "mfgCode": null, - "define": "PUMP_CONFIG_CONTROL_CLUSTER", + "define": "PUMP_CONFIGURATION_AND_CONTROL_CLUSTER", "side": "client", "enabled": 0, "attributes": [ @@ -13898,7 +13898,7 @@ "name": "Pump Configuration and Control", "code": 512, "mfgCode": null, - "define": "PUMP_CONFIG_CONTROL_CLUSTER", + "define": "PUMP_CONFIGURATION_AND_CONTROL_CLUSTER", "side": "server", "enabled": 1, "attributes": [ @@ -15014,7 +15014,7 @@ "name": "Thermostat User Interface Configuration", "code": 516, "mfgCode": null, - "define": "THERMOSTAT_UI_CONFIG_CLUSTER", + "define": "THERMOSTAT_USER_INTERFACE_CONFIGURATION_CLUSTER", "side": "client", "enabled": 0, "attributes": [ @@ -15040,7 +15040,7 @@ "name": "Thermostat User Interface Configuration", "code": 516, "mfgCode": null, - "define": "THERMOSTAT_UI_CONFIG_CLUSTER", + "define": "THERMOSTAT_USER_INTERFACE_CONFIGURATION_CLUSTER", "side": "server", "enabled": 1, "attributes": [ @@ -16332,7 +16332,7 @@ "name": "Temperature Measurement", "code": 1026, "mfgCode": null, - "define": "TEMP_MEASUREMENT_CLUSTER", + "define": "TEMPERATURE_MEASUREMENT_CLUSTER", "side": "client", "enabled": 0, "attributes": [ @@ -16358,7 +16358,7 @@ "name": "Temperature Measurement", "code": 1026, "mfgCode": null, - "define": "TEMP_MEASUREMENT_CLUSTER", + "define": "TEMPERATURE_MEASUREMENT_CLUSTER", "side": "server", "enabled": 1, "attributes": [ @@ -18038,7 +18038,7 @@ "name": "Content Launcher", "code": 1290, "mfgCode": null, - "define": "CONTENT_LAUNCH_CLUSTER", + "define": "CONTENT_LAUNCHER_CLUSTER", "side": "client", "enabled": 0, "commands": [ @@ -18082,7 +18082,7 @@ "name": "Content Launcher", "code": 1290, "mfgCode": null, - "define": "CONTENT_LAUNCH_CLUSTER", + "define": "CONTENT_LAUNCHER_CLUSTER", "side": "server", "enabled": 1, "attributes": [ @@ -23904,7 +23904,7 @@ "name": "Temperature Measurement", "code": 1026, "mfgCode": null, - "define": "TEMP_MEASUREMENT_CLUSTER", + "define": "TEMPERATURE_MEASUREMENT_CLUSTER", "side": "client", "enabled": 0, "attributes": [ @@ -23930,7 +23930,7 @@ "name": "Temperature Measurement", "code": 1026, "mfgCode": null, - "define": "TEMP_MEASUREMENT_CLUSTER", + "define": "TEMPERATURE_MEASUREMENT_CLUSTER", "side": "server", "enabled": 0, "attributes": [ diff --git a/examples/all-clusters-minimal-app/cc13x2x7_26x2x7/main/AppTask.cpp b/examples/all-clusters-minimal-app/cc13x2x7_26x2x7/main/AppTask.cpp index 14645f267a43db..871a5f71d6acc0 100644 --- a/examples/all-clusters-minimal-app/cc13x2x7_26x2x7/main/AppTask.cpp +++ b/examples/all-clusters-minimal-app/cc13x2x7_26x2x7/main/AppTask.cpp @@ -148,7 +148,7 @@ int AppTask::StartAppTask() if (sAppEventQueue == NULL) { PLAT_LOG("Failed to allocate app event queue"); - while (1) + while (true) ; } @@ -157,7 +157,7 @@ int AppTask::StartAppTask() pdPASS) { PLAT_LOG("Failed to create app task"); - while (1) + while (true) ; } return ret; @@ -205,7 +205,7 @@ int AppTask::Init() if (ret != CHIP_NO_ERROR) { PLAT_LOG("PlatformMgr().InitChipStack() failed"); - while (1) + while (true) ; } @@ -213,7 +213,7 @@ int AppTask::Init() if (ret != CHIP_NO_ERROR) { PLAT_LOG("ThreadStackMgr().InitThreadStack() failed"); - while (1) + while (true) ; } @@ -221,7 +221,7 @@ int AppTask::Init() if (ret != CHIP_NO_ERROR) { PLAT_LOG("ConnectivityMgr().SetThreadDeviceType() failed"); - while (1) + while (true) ; } @@ -229,7 +229,7 @@ int AppTask::Init() if (ret != CHIP_NO_ERROR) { PLAT_LOG("PlatformMgr().StartEventLoopTask() failed"); - while (1) + while (true) ; } @@ -237,7 +237,7 @@ int AppTask::Init() if (ret != CHIP_NO_ERROR) { PLAT_LOG("ThreadStackMgr().StartThreadTask() failed"); - while (1) + while (true) ; } @@ -279,7 +279,7 @@ void AppTask::AppTaskMain(void * pvParameter) sAppTask.Init(); - while (1) + while (true) { /* Task pend until we have stuff to do */ if (xQueueReceive(sAppEventQueue, &event, portMAX_DELAY) == pdTRUE) diff --git a/examples/all-clusters-minimal-app/cc13x2x7_26x2x7/main/main.cpp b/examples/all-clusters-minimal-app/cc13x2x7_26x2x7/main/main.cpp index cb0641fbc85ee0..8311c8990aa5c6 100644 --- a/examples/all-clusters-minimal-app/cc13x2x7_26x2x7/main/main.cpp +++ b/examples/all-clusters-minimal-app/cc13x2x7_26x2x7/main/main.cpp @@ -52,7 +52,7 @@ uint32_t heapSize = TOTAL_ICALL_HEAP_SIZE; // ================================================================================ extern "C" void vApplicationStackOverflowHook(void) { - while (1) + while (true) { ; } @@ -85,13 +85,13 @@ int main(void) { // can't log until the kernel is started // PLAT_LOG("GetAppTask().StartAppTask() failed"); - while (1) + while (true) ; } vTaskStartScheduler(); // Should never get here. - while (1) + while (true) ; } diff --git a/examples/all-clusters-minimal-app/infineon/psoc6/src/main.cpp b/examples/all-clusters-minimal-app/infineon/psoc6/src/main.cpp index a7587170607d28..5ac891ae1816f2 100644 --- a/examples/all-clusters-minimal-app/infineon/psoc6/src/main.cpp +++ b/examples/all-clusters-minimal-app/infineon/psoc6/src/main.cpp @@ -59,7 +59,7 @@ void appError(int err) { P6_LOG("!!!!!!!!!!!! App Critical Error: %d !!!!!!!!!!!", err); portDISABLE_INTERRUPTS(); - while (1) + while (true) ; } diff --git a/examples/android/CHIPTool/.idea/jarRepositories.xml b/examples/android/CHIPTool/.idea/jarRepositories.xml index a5f05cd8c87d4a..e34606ccde7a9d 100644 --- a/examples/android/CHIPTool/.idea/jarRepositories.xml +++ b/examples/android/CHIPTool/.idea/jarRepositories.xml @@ -21,5 +21,10 @@