diff --git a/.github/workflows/darwin-tests.yaml b/.github/workflows/darwin-tests.yaml index 4abceefcdcbe33..031263c3d13e40 100644 --- a/.github/workflows/darwin-tests.yaml +++ b/.github/workflows/darwin-tests.yaml @@ -93,9 +93,24 @@ jobs: .environment/gn_out/.ninja_log .environment/pigweed-venv/*.log + - name: Run macOS Darwin Framework Tool Build Debug + working-directory: src/darwin/Framework + # Keep whatever Xcode settings + # for OTHER_CFLAGS exist by using ${inherited}. + # + # Enable -Wconversion by hand as well, because it seems to not be + # enabled by default in the Xcode config. + # + # Disable -Wunguarded-availability-new because we internally use + # APIs we added after our deployment target version. Maybe we + # should change the deployment target version instead? + run: xcodebuild -target "darwin-framework-tool" -sdk macosx OTHER_CFLAGS='${inherited} -Wconversion -Wno-unguarded-availability-new' - name: Delete Defaults run: defaults delete com.apple.dt.xctest.tool continue-on-error: true + - name: Clean Build + run: xcodebuild clean + working-directory: src/darwin/Framework - name: Build Apps timeout-minutes: 90 run: | diff --git a/.github/workflows/darwin.yaml b/.github/workflows/darwin.yaml index c04c044d8a4bb6..6cbfde3a32748b 100644 --- a/.github/workflows/darwin.yaml +++ b/.github/workflows/darwin.yaml @@ -118,19 +118,6 @@ jobs: # should change the deployment target version instead? run: xcodebuild -target "Matter" -sdk macosx OTHER_CFLAGS='${inherited} -Werror -Wconversion -Wno-unguarded-availability-new' working-directory: src/darwin/Framework - - name: Run macOS DFT Build Debug - timeout-minutes: 20 - working-directory: src/darwin/Framework - # Keep whatever Xcode settings - # for OTHER_CFLAGS exist by using ${inherited}. - # - # Enable -Wconversion by hand as well, because it seems to not be - # enabled by default in the Xcode config. - # - # Disable -Wunguarded-availability-new because we internally use - # APIs we added after our deployment target version. Maybe we - # should change the deployment target version instead? - run: xcodebuild -target "darwin-framework-tool" -sdk macosx OTHER_CFLAGS='${inherited} -Wconversion -Wno-unguarded-availability-new' - name: Clean Build run: xcodebuild clean working-directory: src/darwin/Framework