From 40ccae9941c03adb82d2ec3bf826afb905a2dd6f Mon Sep 17 00:00:00 2001 From: Yufeng Wang Date: Wed, 1 Mar 2023 13:01:55 -0800 Subject: [PATCH] Address review comments --- .github/workflows/smoketest-android.yaml | 2 +- src/controller/java/src/chip/tlv/TlvReader.kt | 6 ++---- src/controller/java/src/chip/tlv/TlvWriter.kt | 4 +--- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/.github/workflows/smoketest-android.yaml b/.github/workflows/smoketest-android.yaml index bf6b2d995d55d0..141141abff4c9b 100644 --- a/.github/workflows/smoketest-android.yaml +++ b/.github/workflows/smoketest-android.yaml @@ -38,7 +38,7 @@ jobs: if: github.actor != 'restyled-io[bot]' container: - image: connectedhomeip/chip-build-android:0.6.44 + image: connectedhomeip/chip-build-android:0.6.45 volumes: - "/tmp/log_output:/tmp/test_logs" diff --git a/src/controller/java/src/chip/tlv/TlvReader.kt b/src/controller/java/src/chip/tlv/TlvReader.kt index b4d98f911cbcc8..e281d0ff3d4a7b 100644 --- a/src/controller/java/src/chip/tlv/TlvReader.kt +++ b/src/controller/java/src/chip/tlv/TlvReader.kt @@ -23,9 +23,7 @@ import java.lang.Double.longBitsToDouble import java.lang.Float.intBitsToFloat /** - * Implements Weave/Matter TLV reader that supports all values and tags as defined in the Spec. - * - * See go/weave-tlv-format and go/chip-specs#tlv for specification. + * Implements Matter TLV reader that supports all values and tags as defined in the Spec. * * @param bytes the bytes to interpret */ @@ -382,6 +380,6 @@ class TlvReader(bytes: ByteArray) : Iterable { } } -/** Exception thrown if there was an issue decoding the Weave TLV data. */ +/** Exception thrown if there was an issue decoding the Matter TLV data. */ class TlvParsingException internal constructor(msg: String, cause: Throwable? = null) : RuntimeException(msg, cause) diff --git a/src/controller/java/src/chip/tlv/TlvWriter.kt b/src/controller/java/src/chip/tlv/TlvWriter.kt index f0c4cfa54433eb..ace70593d6cfb8 100644 --- a/src/controller/java/src/chip/tlv/TlvWriter.kt +++ b/src/controller/java/src/chip/tlv/TlvWriter.kt @@ -22,9 +22,7 @@ import com.google.protobuf.ByteString import java.io.ByteArrayOutputStream /** - * Implements Weave/Matter TLV writer that supports all values and tags as defined in the Spec. - * - * See go/weave-tlv-format and go/chip-specs#tlv for specification. + * Implements Matter TLV writer that supports all values and tags as defined in the Spec. * * @param bytes the bytes to interpret */