From 3a6ff45378eacf980b9717d1b4fff80fee37a9ed Mon Sep 17 00:00:00 2001 From: Terence Hampson Date: Mon, 13 Nov 2023 23:26:28 +0000 Subject: [PATCH] Address PR comments --- src/protocols/secure_channel/PairingSession.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/protocols/secure_channel/PairingSession.cpp b/src/protocols/secure_channel/PairingSession.cpp index 3ca91ee44117e7..c8b6d3d546b770 100644 --- a/src/protocols/secure_channel/PairingSession.cpp +++ b/src/protocols/secure_channel/PairingSession.cpp @@ -106,9 +106,13 @@ void PairingSession::DiscardExchange() CHIP_ERROR PairingSession::EncodeSessionParameters(TLV::Tag tag, const Optional & providedMrpConfig, TLV::TLVWriter & tlvWriter) { + // TODO: https://github.com/project-chip/connectedhomeip/issues/30456. Based on the spec we need to send values here now, + // but it is not entirely clear what we should be sending here when `providedMrpConfig.HasValue() == false`. This is a + // followup TODO. ReliableMessageProtocolConfig mrpLocalConfig = GetDefaultMRPConfig(); if (providedMrpConfig.HasValue()) { + mrpLocalConfig = providedMrpConfig.Value(); } TLV::TLVType mrpParamsContainer;