From 1952272ab0b5c567d3cafb15f2a1085182c72743 Mon Sep 17 00:00:00 2001 From: Boris Zbarsky Date: Thu, 2 Mar 2023 12:53:52 -0500 Subject: [PATCH] Enable -Wconversion in minimal-mdns records. (#25406) --- src/lib/dnssd/minimal_mdns/records/BUILD.gn | 2 ++ src/lib/dnssd/minimal_mdns/records/ResourceRecord.cpp | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/lib/dnssd/minimal_mdns/records/BUILD.gn b/src/lib/dnssd/minimal_mdns/records/BUILD.gn index 69dc2dd9e05e42..9e0dbd4b1143fe 100644 --- a/src/lib/dnssd/minimal_mdns/records/BUILD.gn +++ b/src/lib/dnssd/minimal_mdns/records/BUILD.gn @@ -31,4 +31,6 @@ static_library("records") { "${chip_root}/src/lib/dnssd/minimal_mdns/core", "${chip_root}/src/platform", ] + + cflags = [ "-Wconversion" ] } diff --git a/src/lib/dnssd/minimal_mdns/records/ResourceRecord.cpp b/src/lib/dnssd/minimal_mdns/records/ResourceRecord.cpp index ce0b7e8e58e2e0..689a31bb05b3cb 100644 --- a/src/lib/dnssd/minimal_mdns/records/ResourceRecord.cpp +++ b/src/lib/dnssd/minimal_mdns/records/ResourceRecord.cpp @@ -56,13 +56,13 @@ bool ResourceRecord::Append(HeaderRef & hdr, ResourceType asType, RecordWriter & switch (asType) { case ResourceType::kAdditional: - hdr.SetAdditionalCount(hdr.GetAdditionalCount() + 1); + hdr.SetAdditionalCount(static_cast(hdr.GetAdditionalCount() + 1)); break; case ResourceType::kAuthority: - hdr.SetAuthorityCount(hdr.GetAuthorityCount() + 1); + hdr.SetAuthorityCount(static_cast(hdr.GetAuthorityCount() + 1)); break; case ResourceType::kAnswer: - hdr.SetAnswerCount(hdr.GetAnswerCount() + 1); + hdr.SetAnswerCount(static_cast(hdr.GetAnswerCount() + 1)); break; } }