From 191df0a89a6aa08e119332eb4675195032a34dcc Mon Sep 17 00:00:00 2001 From: Andrei Litvin Date: Fri, 5 May 2023 11:42:53 -0400 Subject: [PATCH] Fix rule parser logic (#26393) Co-authored-by: Andrei Litvin --- scripts/py_matter_idl/matter_idl/lint/lint_rules_parser.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/scripts/py_matter_idl/matter_idl/lint/lint_rules_parser.py b/scripts/py_matter_idl/matter_idl/lint/lint_rules_parser.py index b8ac5d7a2b4f97..f3b2c6dabdf620 100755 --- a/scripts/py_matter_idl/matter_idl/lint/lint_rules_parser.py +++ b/scripts/py_matter_idl/matter_idl/lint/lint_rules_parser.py @@ -62,10 +62,9 @@ def DecodeClusterFromXml(element: xml.etree.ElementTree.Element): # - name (general name for this cluster) # - code (unique identifier, may be hex or numeric) # - attribute with side, code and optional attributes - try: name = element.find('name') - if not name or not name.text: + if name is None or not name.text: raise ElementNotFoundError('name') name = name.text.replace(' ', '') @@ -105,7 +104,7 @@ def DecodeClusterFromXml(element: xml.etree.ElementTree.Element): name=cmd.attrib["name"], code=parseNumberString(cmd.attrib['code']))) code = element.find('code') - if not code: + if code is None: raise Exception("Failed to find cluster code") return DecodedCluster(