From 1335804f56b824bf55b6309051f50281af9f6e3f Mon Sep 17 00:00:00 2001 From: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com> Date: Fri, 13 Oct 2023 13:05:57 -0400 Subject: [PATCH] =?UTF-8?q?[Silabs]Clarify=20a=20warning=20trace=20for=20b?= =?UTF-8?q?rd4186a/87c=20and=20cleanup=20unsupported=20erro=E2=80=A6=20(#2?= =?UTF-8?q?9740)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Clarify a warning trace for brd4186a/87c and cleanup unsupported error message * Apply suggestions from code review Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com> --------- Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com> --- third_party/silabs/silabs_board.gni | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/third_party/silabs/silabs_board.gni b/third_party/silabs/silabs_board.gni index 6910e410a4e2f0..cd433ed61da49c 100644 --- a/third_party/silabs/silabs_board.gni +++ b/third_party/silabs/silabs_board.gni @@ -142,7 +142,9 @@ if (silabs_board == "BRD4304A") { silabs_family = "efr32mg21" silabs_mcu = "EFR32MG21A020F1024IM32" } else if (silabs_board == "BRD4186A" || silabs_board == "BRD4187A") { - print("RevA is deprecated, We suggest using BRD4186C (rev C)") + variant = string_replace(silabs_board, "A", "C") + print( + "${silabs_board} is deprecated. It is recommended to use the 'C' variant of this board (${variant})") silabs_family = "efr32mg24" silabs_mcu = "EFR32MG24A010F1536GM48" } else if (silabs_board == "BRD4186C") { @@ -202,9 +204,9 @@ if (silabs_board == "BRD4304A") { silabs_family = "mgm24" silabs_mcu = "MGM240SD22VNA" } else { - print( - "Please provide a valid value for SILABS_BOARD env variable (currently supported BRD4304A, BRD4161A, BRD4163A, BRD4164A BRD4166A, BRD4170A, BRD4186C, BRD4187C, BRD2601B, BRD2703A, BRD4317A, BRD2704A)") - assert(false, "The board ${silabs_board} is unsupported") + assert( + false, + "The board ${silabs_board} is unsupported. A list of supported board can be found here https://t.ly/_b3SK") } # qr code cannot be true if lcd is disabled