Skip to content

Commit

Permalink
Print framework log when framework build fails for darwin-frawework-t…
Browse files Browse the repository at this point in the history
…ool. (#27862)
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Jan 16, 2024
1 parent 0e110a1 commit 1236984
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions scripts/build/build_darwin_framework.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,15 @@ def run_command(command):

with open(args.log_path, "wb") as f:
f.write(command_log)

if returncode != 0:
# command_log is binary, so decoding as utf-8 might technically fail. We don't want
# to throw on that.
try:
print("Failure log: {}".format(command_log.decode()))
except Exception:
pass

return returncode


Expand Down

0 comments on commit 1236984

Please sign in to comment.