From a68241b2ef6942570d934b057a675b3470f1dab5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mikael=20M=C3=B8ller?= Date: Thu, 9 Nov 2023 09:32:22 -0800 Subject: [PATCH] Update yaml_test_folder.py (#21) * Update yaml_test_folder.py * Update test_sdk_yaml_collection.py * Update unittests.yml Don't run old code for unit tests --- .github/workflows/unittests.yml | 2 +- app/tests/yaml_tests/test_sdk_yaml_collection.py | 3 ++- .../sdk_tests/support/yaml_tests/models/yaml_test_folder.py | 1 - 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/unittests.yml b/.github/workflows/unittests.yml index 418f344d..ab9ed88a 100644 --- a/.github/workflows/unittests.yml +++ b/.github/workflows/unittests.yml @@ -1,7 +1,7 @@ name: Unit Tests on: - pull_request_target: + pull_request: types: [opened, synchronize, reopened] push: branches: diff --git a/app/tests/yaml_tests/test_sdk_yaml_collection.py b/app/tests/yaml_tests/test_sdk_yaml_collection.py index db81d4cc..0519cefb 100644 --- a/app/tests/yaml_tests/test_sdk_yaml_collection.py +++ b/app/tests/yaml_tests/test_sdk_yaml_collection.py @@ -17,6 +17,7 @@ import pytest +from test_collections.sdk_tests.support.paths import SDK_CHECKOUT_PATH from test_collections.sdk_tests.support.yaml_tests.models.test_declarations import ( YamlCaseDeclaration, YamlCollectionDeclaration, @@ -32,7 +33,7 @@ ) VERSION_FILE_FILENAME = ".version" -VERSION_FILE_PATH = Path("/app/backend/test_collections/sdk_tests/sdk_checkout/") +VERSION_FILE_PATH = SDK_CHECKOUT_PATH @pytest.fixture diff --git a/test_collections/sdk_tests/support/yaml_tests/models/yaml_test_folder.py b/test_collections/sdk_tests/support/yaml_tests/models/yaml_test_folder.py index b8362b43..a9aaa313 100644 --- a/test_collections/sdk_tests/support/yaml_tests/models/yaml_test_folder.py +++ b/test_collections/sdk_tests/support/yaml_tests/models/yaml_test_folder.py @@ -21,7 +21,6 @@ VERSION_FILE_FILENAME = ".version" - class YamlTestFolder: """Representing a folder with Test YAML files.