Skip to content

Menu height should have a minimum value of 5 lines #1

@suucss

Description

@suucss

Firstly, congratulations on this great project! Thanks for your efforts in broadening the reach and usage of HackerNews / YCombinator!

I've noticed an issue with the terminal menu when the terminal height is too small. The menu, which consists of one line for "option", three lines for "summary", "open", and "close", plus one bottom line, scales according to a ratio of terminal height. However, when the terminal height becomes too small, the menu's content becomes incomplete even invisible as it doesn’t have enough lines to display all its elements.

To ensure the menu remains readable, I suggest setting a minimum height of 5 lines. This way, all the content will always be visible, regardless of the terminal height. Below are some screenshots showing how the menu height changes along with terminal height.

normal case

Screenshot_20241112_164126

edge of normal and abnormal

Screenshot_20241112_164151

2 lines of options

Screenshot_20241112_164212

1 lines of options

Screenshot_20241112_164244

options are invisible

Screenshot_20241112_164300

It would be a good news and I would appreciate it if you can make a small fix on that :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions