Skip to content

Conversation

@ben
Copy link
Member

@ben ben commented Jun 4, 2014

Various edits, and re-exported graphics at 300dpi. Discovered some that were missing, and notated them in #42.

@ben ben added this to the Chapter 3 - Git Branching milestone Jun 4, 2014
@ben
Copy link
Member Author

ben commented Jun 6, 2014

Ready to merge, if'n you like it.

@schacon
Copy link
Member

schacon commented Jun 9, 2014

Mostly small changes, though I did move 'Undoing Merges' to Ch7 as I felt it was a little advanced at this point in the narrative.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a weak preference, but I'm wondering if this is the right way to go. It'll show up as

that we'll cover later.

…in HTML and a digital PDF, but all that linky information will be lost in print. I kind of like using that we'll cover later on, in <<_git_stashing>>., because it'll show up as:

that we'll cover later on, in Section 3.2, Stashing.

Like I said, it's a weak preference. If you have a strong opinion either way, I'm cool with it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I like your way better, I'll change it.

@ben
Copy link
Member Author

ben commented Jun 10, 2014

Just the one question about naming cross-references; otherwise this looks really good.

schacon added a commit that referenced this pull request Jun 10, 2014
@schacon schacon merged commit c3e2621 into master Jun 10, 2014
@schacon schacon deleted the chapter-3-polish branch June 10, 2014 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants