Skip to content

Create note with link to git-rebase.io #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Create note with link to git-rebase.io #1449

merged 1 commit into from
Jul 2, 2020

Conversation

HonkingGoose
Copy link
Contributor

What happens when merging this pull-request:

Pros and cons of proposed change:

Pro:

  • We skip the work of creating a new tutorial/sandbox for git rebase.
  • No maintenance costs for maintaining a separate guide.
  • The linked guide contains instructions on setting up a 'sandbox environment', where users can just noodle around and learn how git rebase works in depth.
  • I think that after reading the guide, users will be equipped to use git rebase in their own workflow effectively.

Con:

  • We have no control over the editorial tone of the guide.
  • The site might go down/go out of date.
  • Content of the guide is not saved in our own repository.

Discussion:

I've had a lot of time to learn and use git rebase, and have opened some (lengthy) issues in the past (#1247 and #1329) on how to improve the ProGit2 teaching material for git rebase.
I've come to the conclusion that we could just link to the great guide made by Drew DeVault on git-rebase.io and be done with this annoying HonkingGoose 😄 ❇️

Copy link
Member

@ben ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I like this, especially for people for whom our style doesn't work. Just a couple of formatting fixes, then we'll be good to go.

@HonkingGoose HonkingGoose changed the title Create section with link to git-rebase.io Create note with link to git-rebase.io Jul 2, 2020
@HonkingGoose
Copy link
Contributor Author

Just a couple of formatting fixes, then we'll be good to go.

I've made the formatting changes you requested. Also I moved the link up one line, so that the link is right after the introductory text.

It's ready for another review. 👍

@ben
Copy link
Member

ben commented Jul 2, 2020

@ben ben merged commit 0af7f12 into progit:master Jul 2, 2020
@HonkingGoose HonkingGoose deleted the feature/add-link-to-git-rebase-io-website branch July 3, 2020 10:30
@HonkingGoose
Copy link
Contributor Author

Thanks for merging my work in! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to, or incorporate (parts) of website https://git-rebase.io/ Add git rebase -i [SHA1] example.
2 participants