Skip to content

SVG images checked and fixed (some redesigned) #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Aug 29, 2019
Merged

Conversation

max123kl
Copy link
Contributor

font-weight altered to "700"
text positions and color fixed
some files redesigned to look as "former" PNG files

test files deleted

I created an HTML table that allows a straight comparison of SVG and PNG files.
I noticed some minor issues, which I want to fix as soon as possible.
The files have to be inspected closely

jnavila and others added 16 commits August 8, 2019 22:40
customized color scheme that better matches the former look
Texts at position, color and size adapted to the look of the corresponding PNG file
added full-size SVG for testing
font-weight altered to "700"
text positions and color fixed
some files redesigned to look as former PNG files
@ben
Copy link
Member

ben commented Aug 27, 2019

I created an HTML table that allows a straight comparison of SVG and PNG files.

✨ So useful, thanks! I'm just doing a spot check, this won't be exhaustive.

Looks like these arrows got turned around:

image

It also looks like some of the refs got resized in a weird way. That probably dates from my Sketch export. We don't need to fix this right away, but I just thought I'd make a note.

image

Otherwise this looks great!

arrow direction fixed
@max123kl
Copy link
Contributor Author

Looks like these arrows got turned around:

Yes, I didn't notice. In general, I discovered that all arrowheads were converted incorrectly. In many cases it is not necessary to change this, because it is not relevant for the content of the drawing. It is only an appearance problem.
clean.svg fixed.

It also looks like some of the refs got resized in a weird way.

I've noticed that. In some cases I had already corrected that.
I will check the diagrams again and touch them up one by one. But it will take some time to fix all the files.

@ben
Copy link
Member

ben commented Aug 28, 2019

Let me know when you think this is ready, it looks great to me.

@max123kl
Copy link
Contributor Author

max123kl commented Aug 29, 2019

As far as I can see, all the files are ready to merge.
If there is still an issue, please notify me.

For checking purposes I have updated the HTML table.

@ben
Copy link
Member

ben commented Aug 29, 2019

😻

@ben ben merged commit 3b91889 into progit:master Aug 29, 2019
@max123kl max123kl deleted the new_svg2 branch September 7, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants