ch05 distributed image is incorrect?

[morefreeze]

It appears in here. From context (start with line 120), we know Jessica works on both branch featureA and featureB, John works on featureA only, and Josie works on featureB (featureBee). So let's take a look at the image about workflow. John and Josie their name draw conversely in square box, is it right?

So I recommend whether we rename John as Alice who works on featureA, Josie as Bob who works on featureB(ee), Jessica as Candy who works on both. The origin naming is too confused.

[jnavila]

@ben Would you prefer changing the text or the picture (picture would make more sense)?

[ben]

Yeah, changing the figure makes more sense, though I like the suggestion to change the names throughout. Can we use Carol instead of Candy, though?

[jnavila]

Sorry, I don't understand your question. Where does Candy appear in this story?

[jnavila]

Ah, OK, @ben. You meant changing the text as described by @morefreeze . Well, I don't have the editor application for the pictures, so this change can only go half-way.

[YueLinHo]

So, using application Sketch on Mac to edit \diagram-source\progit.sketch file, then exporting png file.

• Josie -> Alice (work on feature A)
• John -> Bob (work on feature B)
• Jessica -> Carol (work on feature A and B)

And modifying the file \book\05-distributed-git\sections\contributing.asc

• John -> Alice (work on feature A)
• Josie -> Bob (work on feature B)
• Jessica -> Carol (work on feature A and B)

[YueLinHo]

Why close it?

[morefreeze]

@YueLinHo Sorry, I thought you have edit the picture and merge PR. It's my mistake.

[YueLinHo]

😄 I wish I could. I need a Mac and Sketch 3.