PR implements batching #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the commit every write to the NetworkStream used to sent on each separate tcp packet. Added throttling for request writer to accumulate much more request to combine
* use interlocked read of pending bytes * use shared dummy array
karlovnv
commented
Sep 6, 2019
remove hard coded write buffer size
aensidhe
requested changes
Sep 9, 2019
karlovnv
commented
Sep 11, 2019
| var count = 0; | ||
| while ((request = GetRequest()) != null) | ||
| UInt64 length = 0; |
There was a problem hiding this comment.
This is the only place where var is not recommended.
|
@aensidhe I've finished with working on your comment, please take a look |
aensidhe
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a look at issue #146