Support undefined props and private variants applied last #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, as the props value was required, the (compound)variant(s) matching the default value were applyed. If no style was expected, a "default" variant with an empty declaration was required. Now, you only need to define props as optional and if no fallback is passed, no style will be applyed.
cr0cK
force-pushed
the
feature/experiments-undefined-props
branch
from
157c32b to
ba24e7c
Compare
Having private properties applied last allows to use public variants and override a few props by using an extra private variant.
cr0cK
force-pushed
the
feature/experiments-undefined-props
branch
from
ba24e7c to
578768c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Prop values passed to
variant(s)andcompoundVariant(s)are now optional.It allows to not apply default styles or having to create "empty variant" for default cases.
Private variants (prop starting by
_) now overrides composed variants got from an existing variant declaration.For example, let's consider a Button on which the "primary" variant define a white color, if a private variant is defining a different color, it's possible to override the primary color like this:
Benefits
Possible Drawbacks
Testing Instructions
Checklist