Skip to content

Sign macos prebuilds #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Sign macos prebuilds #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6db6899
Sign the build commits so they can be used on macOS
Stefterv Dec 6, 2024
624c171
env not with
Stefterv Dec 6, 2024
b170b45
simplified solution
Stefterv Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,16 @@ jobs:
architecture: ${{ matrix.arch }}
- name: Setup Ant
uses: cedx/setup-ant@v3
- name: Install Certificates for Code Signing
if: ${{ matrix.os_prefix == 'macos' }}
uses: apple-actions/import-codesign-certs@v3
with:
p12-file-base64: ${{ secrets.CERTIFICATES_P12 }}
p12-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }}
- name: Build Release
run: ant -noinput -buildfile build/build.xml ${{ matrix.os_prefix }}-dist -Dversion="${{ github.sha }}"
env:
PROCESSING_APP_SIGNING: true
- name: Add artifact
uses: actions/upload-artifact@v4
with:
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,16 @@ jobs:
architecture: ${{ matrix.arch }}
- name: Setup Ant
uses: cedx/setup-ant@v3
- name: Install Certificates for Code Signing
if: ${{ matrix.os_prefix == 'macos' }}
uses: apple-actions/import-codesign-certs@v3
with:
p12-file-base64: ${{ secrets.CERTIFICATES_P12 }}
p12-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }}
- name: Build Release
run: ant -noinput -buildfile build/build.xml ${{ matrix.os_prefix }}-dist -Dversion="${{ github.sha }}"
env:
PROCESSING_APP_SIGNING: true
- name: Add artifact
uses: actions/upload-artifact@v3
id: upload
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ jobs:
- name: Build Release
run: ant -noinput -buildfile build/build.xml ${{ matrix.os_prefix }}-dist -Dversion="${{ needs.version.outputs.version }}"
env:
PROCESSING_APP_SIGNING: true
PROCESSING_APP_PASSWORD: ${{ secrets.PROCESSING_APP_PASSWORD }}
PROCESSING_APPLE_ID: ${{ secrets.PROCESSING_APPLE_ID }}
PROCESSING_TEAM_ID: ${{ secrets.PROCESSING_TEAM_ID }}
Expand Down
2 changes: 1 addition & 1 deletion build/build.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,7 +778,7 @@
</exec>
</target>

<target name="macos-dist-sign" if="env.PROCESSING_APP_PASSWORD">
<target name="macos-dist-sign" if="env.PROCESSING_APP_SIGNING">
<echo>
Code signing will only work if you have a $99/yr Apple developer ID.
</echo>
Expand Down
Loading