Skip to content

Incorrect highlighting when selecting an error from the list that's in a different tab #1112

Open
@joshgiesbrecht

Description

@joshgiesbrecht

Most appropriate sub-area of Processing 4?

PDE

Processing version

4.4.4

Operating system

Windows 10, Debian Linux

Steps to reproduce this

"1.Open a sketch that has multiple tabs.

2.Add some errors and/or warnings in each tab.

3.Click the 'Errors' panel in the bottom of the PDE. Click on one of the errors that is in a tab you don't have open. The highlighting will likely be in the wrong place, and not match up with a line start/end correctly."

snippet

// Paste your code below :)

void setup() {

}

void draw() {

}

Additional context

Found a small one-line fix already which I don't think is too 'hacky'; we just need to activate the selected tab before looking up the relevant character offset for the line number. (It's basing the highlight on the char offset of that line number in the currently visible tab.)

Would you like to work on the issue?

yes plz

Metadata

Metadata

Labels

bugSomething isn't workinggood first issueGood for newcomershelp wantedExtra attention is neededpdeProcessing Development Environment

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions