Fixing keyTyped() for dev-2.0 branch

[perminder-17]

Resolves #7805

Changes:

Screenshots of the change:

PR Checklist

• npm run lint passes
• Inline reference is included / updated
• Unit tests are included / updated

[AhmedMagedC]

Hi, @perminder-17
may i know why did you choose to use e.repeat? as i said in my PR e.repeat always results in False value, the main solution was to allow for the same char to be pressed consecutively more than once while preventing from printing the same char if the user holds down the key.

[perminder-17]

Hi @AhmedMagedC , Really thanks for raising your concerns, these discussions are really very appreciated in PROCESSING FOUNDATION so if anything goes wrong could be fixed :).

e.repeat is to distinguish a genuine second tap (where repeat stays false) from the flood of auto-repeat events you get when the key is held down. i.e. if you press key 2 times, it is false but if you hold the key for 2-3 seconds it should be true.

Here's the screenshot from the mdn docs

Can you please confirm what you get when you hold any key for maybe 3-4 seconds, do you get e.repeat as true?

If that's again false, can you please let me know what browser and version you using? here's the browser compatibility written " https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/repeat?utm_source=chatgpt.com " maybe due to compatibility issue you could be getting always false?

Also, in your PR i.e. #7808 as I can see you are first setting isKeyRepeated variable to true only when e.repeat is true. So it means you are using e.repeat any way or the other to check stuffs.

In your PR, it's something like ;

  if (e.repeat) {
     this._setProperty('isKeyRepeated', true);  // isKeyRepeated is used further.
    return;
  }

I am really sorry if I am not referring to the same thing you are talking about? Can you please let me know if I am clear to explain the use of e.repeat, or maybe feel free to raise any other concerns you have. :)

[AhmedMagedC]

Hi @perminder-17, the issue is that e.repeat results in false even if you hold down the key,

but when i tried to print the e.repeat value in fn._onkeydown = function(e) {} e.repeat gives true if you hold down, but it gives always false for fn._onkeypress = function(e) {}

i tested on chrome & avast & Microsoft edge

[perminder-17]

e.repeat value in fn._onkeydown = function(e) {} e.repeat gives true if you hold down, but it gives always false for fn._onkeypress = function(e) {}

Okay, thanks for reporting.

But I also checked on firefox and chrome (at linux) and everything was working correctly as expected. This looks like could be a browser specific issue. Someone previously had a similar issue with this. : https://stackoverflow.com/questions/53200698/onkeypress-repeat-always-returns-false-in-some-browsers

Workaround could be, maybe we will move e.repeat in fn.onkeyDown and then probably use that in fn.onkeyPress.
Do you agree with this @davepagurek or could be a different workaround for it. I think its a browser specific issue, are you also able to reproduce the same in your system as well?