Consistent movedX
and movedY
behaviour across zoom levels
#7795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7790
Approach Used:
_updateMouseCoords()
is called at the beginning of the existing function to store the previous frame’s positions.mouseX
,mouseY
, themovedX
andmovedY
values are derived in terms ofdeltaX
anddeltaY
usingpmouseX
andpmouseY
values and the current values of X and Y.Alternative Approach:
Instead of calling
_updateMouseCoords()
at the beginning , we could use variables to store previous values which could then be used to find delta.But, In my opinion there is no point in using extra variable to track the previous values. So, to avoid this manual tracking and leveraging the existing function, used the approach given earlier.
Observations:
Previously, the behaviour was:
Screencast.from.07-05-25.12.12.39.AM.IST.webm
Now, after fixing,
Screencast.from.07-05-25.12.08.48.AM.IST.webm
Browser Tested:
Chrome
Firefox
npm run lint
passes